Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(vocabulary): fix for vocabulary management for ScalarDeclaration #662

Conversation

sanketshevkar
Copy link
Member

Closes #656

When adding vobulary terms as decorators to the model, englishMissingTermGenerator failed for Scalars. Fixed the issue and modified a test.

Changes

  • Optionally chained the function call to getProperties for the declarations object. As Scalars don't have properties, the function won't get called.

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from fork:branchname

@sanketshevkar sanketshevkar requested a review from a team June 28, 2023 11:02
@mttrbrts mttrbrts enabled auto-merge (squash) June 28, 2023 11:03
@mttrbrts mttrbrts merged commit 7926fae into accordproject:main Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vocabulary management broken for Scalars
2 participants