Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vocabulary management broken for Scalars #656

Closed
sanketshevkar opened this issue May 31, 2023 · 0 comments · Fixed by #662
Closed

Vocabulary management broken for Scalars #656

sanketshevkar opened this issue May 31, 2023 · 0 comments · Fixed by #662

Comments

@sanketshevkar
Copy link
Member

Bug Report 🐛

Expected Behavior

Should be able to add vocabulary annotations for Scalar Declarartions

Current Behavior

I was testing the vocab file generated by the code generator I've written. While testing it on this repl https://replit.com/join/xeqmqanuuo-sanketshevkar
I'm not able able to add a command set to the model manager when any scalar value is present in the .cto file. In other cases it's working fine.
I am getting the following error.

TypeError: decl.getProperties is not a function
    at /home/runner/AccordProjectConcerto-Vocabulary/node_modules/@accordproject/concerto-vocabulary/lib/vocabularymanager.js:254:22
    at Array.forEach (<anonymous>)
    at /home/runner/AccordProjectConcerto-Vocabulary/node_modules/@accordproject/concerto-vocabulary/lib/vocabularymanager.js:230:40
    at Array.forEach (<anonymous>)
    at VocabularyManager.generateDecoratorCommands (/home/runner/AccordProjectConcerto-Vocabulary/node_modules/@accordproject/concerto-vocabulary/lib/vocabularymanager.js:229:38)
    at Object.<anonymous> (/home/runner/AccordProjectConcerto-Vocabulary/index.js:126:33)
    at Module._compile (node:internal/modules/cjs/loader:1101:14)
Hint: hit control+c anytime to enter REPL.

Possible Solution

Steps to Reproduce

https://replit.com/join/xeqmqanuuo-sanketshevkar

Possible Implementation

Need to fix VocabularyManager from @accordproject/concerto-vocabulary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant