Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(performance): refactoring inefficient duplication checking nested for loops #587

Conversation

stefanblaginov
Copy link
Contributor

@stefanblaginov stefanblaginov commented Jan 6, 2023

Refactoring inefficient duplicate-checking nested for loops. The refactoring methodology follows @mttrbrts's (#582) in replacing the nested for loops with ES6's Set structures.

Inefficiency discovery methodology: inspecting all loops in codebase.

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from fork:branchname

@stefanblaginov stefanblaginov requested review from a team, DianaLease, dselman and mttrbrts January 6, 2023 15:11
@mttrbrts mttrbrts merged commit 9e91f31 into accordproject:main Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants