perf(core): make classDeclaration validation more CPU efficient #582
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change improves the algorithmic complexity of validating ClassDeclarations from O(n^2) to O(n). This gives a significant improvement for models with large numbers of class declarations.
Previously, we would compare each ClassDeclaration name with every other to detect duplicates. The implementation uses ES6's
Set
structure to more efficiently count duplicates.Flags
Author Checklist
--signoff
option of git commit.main
fromfork:branchname