feat(stringvalidator): client provided regex #487
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts the changes introduced in #484 to adopt the RE2 engine. The engine has some constraints (no browser support, memory limits etc.), so I'd like to simplify Concerto, but allow consumers to supply their own engine where they can make own judgements on the tradeoffs.
Changes
RegExp
engine by default for all platforms.ModelManager
constructor to allow a client to provide their own RegExp engine.Flags
Author Checklist
--signoff
option of git commit.master
fromfork:branchname