BREAKING CHANGE(core): limit regex to ReDoS safe patterns #484
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the Regular Expression engine for String Validators to use re2-wasm. re2-wasm is a drop-in replacement that prohibits back-tracking. This protects us from Regular Expression Denial of Service (ReDoS) attacks on the server. Client-side code should directly validate user-provided regexes if they are being evaluated client-side.
Changes
StringValidator
inconcerto-core
Flags
re2-wasm
also uses Unicode mode by default.re2-wasm
is not supported in the browser, so we fallback toRegExp
(i.e. the previous behaviour).Author Checklist
--signoff
option of git commit.master
fromfork:branchname