Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): update index.js for better type generation (resolves #402) #403

Merged
merged 1 commit into from
Mar 22, 2022

Conversation

sstone1
Copy link
Contributor

@sstone1 sstone1 commented Mar 22, 2022

#402

Change index.js so that instead of requiring and exporting in one shot, like this:

module.exports.SecurityException = require('./lib/securityexception');

It is separated, like this:

const SecurityException = require('./lib/securityexception');

module.exports = {
    SecurityException
}

This results in better, more usable type definitions.

Signed-off-by: Simon Stone [email protected]

Copy link
Member

@mttrbrts mttrbrts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that this is only a breaking change for TypeScript clients?

@sstone1
Copy link
Contributor Author

sstone1 commented Mar 22, 2022

I believe that this is only a breaking change for TypeScript clients?

Correct!

@mttrbrts mttrbrts merged commit 75c5b42 into accordproject:master Mar 22, 2022
@sstone1 sstone1 deleted the issue-402 branch March 22, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants