-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TypeScript types are difficult to use #402
Comments
sstone1
pushed a commit
to sstone1/concerto
that referenced
this issue
Mar 22, 2022
…rdproject#402) Signed-off-by: Simon Stone <[email protected]>
sstone1
pushed a commit
to sstone1/concerto
that referenced
this issue
Mar 22, 2022
…rdproject#402) Signed-off-by: Simon Stone <[email protected]>
sstone1
pushed a commit
to sstone1/concerto
that referenced
this issue
Mar 25, 2022
…ccordproject#402) Signed-off-by: Simon Stone <[email protected]>
sstone1
pushed a commit
to sstone1/concerto
that referenced
this issue
Mar 25, 2022
…ccordproject#402) Signed-off-by: Simon Stone <[email protected]>
sstone1
pushed a commit
to sstone1/concerto
that referenced
this issue
Mar 25, 2022
…ccordproject#402) Signed-off-by: Simon Stone <[email protected]>
sstone1
pushed a commit
to sstone1/concerto
that referenced
this issue
Mar 25, 2022
…ccordproject#402) Signed-off-by: Simon Stone <[email protected]>
mttrbrts
pushed a commit
that referenced
this issue
Mar 25, 2022
) (#405) * fix(types): typescript type generation improvements (contributes to #402) Signed-off-by: Simon Stone <[email protected]> * fix(types): use @type annotation suggestion from @mttrbrts Signed-off-by: Simon Stone <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The TypeScript types are generated as follows:
This means that you end up having to write verbose code to use the types:
The problem stems from the way they are exported from
index.js
:Switching them to this pattern:
Results in more common TypeScript types:
And easier usage of those types:
The text was updated successfully, but these errors were encountered: