fix(aliasing): added new resolvedName property to typeIdentifier object for import aliased declrations

[sanketshevkar]

PartialyCloses accordproject/concerto#972

Added to new optionalresolvedName property to TypeIdenifier. This is to preserve the aliased name property which will have the local name for the aliased type. resolvedName will contain the origonal type name. It will get added only for the declrations ot types that "imported and aliased".

With the current implementation the value of the name property is different for a normal ast (local name) vs a resolved ast (original type name). This can be very confusing.

The part that would close this issue would be adding unit tests to cover the edge cases in concerto packages.

Related Issues

• Issue fix(aliasing): resolve aliased import type name to imported type name #32
• Pull Request #

Author Checklist

• Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
• Vital features and changes captured in unit and/or integration tests
• Commits messages follow AP format
• Extend the documentation, if necessary
• Merging to main from fork:branchname

[coveralls]

Pull Request Test Coverage Report for Build 12807110955

Details

• 6 of 6 (100.0%) changed or added relevant lines in 2 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.3%) to 96.104%

---

Totals
Change from base Build 12138117157:	0.3%
Covered Lines:	90
Relevant Lines:	90

---

💛 - Coveralls

[ekarademir]

If you use closes in the description, github will go ahead and close the issue after the PR is merged. So could you not use closes in the title or description? Unless this PR will close the issue.

[ekarademir]

Why add a comment here? This comment doesn't explain the code or notify anything. Maybe just add a comment to the PR? Or raise it in Discord?

Could you remove it before you merge this?

[ekarademir]

The code is adding types defined in the current CTO to the types table.

[sanketshevkar]

Sorry I had forgot to remove the comment from the older PR.

[sanketshevkar]

@ekarademir I thought it works only if the issues are logged in same repo as the PR. I'm not sure though. I'll make an update in either case.

Also I've fixed the coverage drop by fixing the aliasing test.