Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(aliasing): resolve aliased import type name to imported type name #32

Merged
merged 2 commits into from
Dec 3, 2024
Merged

fix(aliasing): resolve aliased import type name to imported type name #32

merged 2 commits into from
Dec 3, 2024

Conversation

muhabdulkadir
Copy link
Contributor

@muhabdulkadir muhabdulkadir commented Dec 2, 2024 •
edited
Loading

Closes #

Changes

  • resolve aliased import type name to imported type name

Related Issues

  • Issue #[<950>

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from fork:branchname

@muhabdulkadir muhabdulkadir changed the title main fix(aliasing): resolve aliased import type name to imported type name Dec 2, 2024
chore(*): update test
1a1b353 
Signed-off-by: muhammed-abdulkadir <[email protected]>
@coveralls
Copy link

coveralls commented Dec 3, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12135189764

Details

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.09%) to 95.833%
Totals Coverage Status
Change from base Build 12113309943: 0.09%
Covered Lines: 86
Relevant Lines: 86
💛 - Coveralls

mttrbrts
mttrbrts approved these changes Dec 3, 2024
View reviewed changes
test/cto/aliasedImport.json Show resolved Hide resolved
muhabdulkadir
muhabdulkadir commented Dec 3, 2024
View reviewed changes
test/cto/aliasedImportResolved.json
"superType": {
"$class": "[email protected]",
"name": "d",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the impact of the change in the metamodel

@mttrbrts mttrbrts merged commit 2fb1630 into accordproject:main Dec 3, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mttrbrts mttrbrts mttrbrts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@muhabdulkadir @coveralls @mttrbrts