feat(csharp,java): support aliasing imports #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
August 1, 2024 00:18
Signed-off-by: Jaskeerat Singh Saluja <[email protected]>
- Earlier non-imported types gave error. Signed-off-by: Jaskeerat Singh Saluja <[email protected]>
Signed-off-by: Jaskeerat Singh Saluja <[email protected]>
Signed-off-by: Jaskeerat Singh Saluja <[email protected]>
salujajaskeerat
changed the title
|
Can you update the title of the commit to follow the conventional commit style please? |
ekarademir
previously requested changes
Aug 6, 2024
salujajaskeerat
changed the title
Signed-off-by: Jaskeerat Singh Saluja <[email protected]>
salujajaskeerat
changed the title
added 2 commits
September 3, 2024 16:16
Signed-off-by: Jaskeerat Singh Saluja <[email protected]>
Signed-off-by: Jaskeerat Singh Saluja <[email protected]>
|
Below contains the code-coverage reports from the changes made in the concerto-codegen for csharp and java
|
Signed-off-by: Jaskeerat Singh Saluja <[email protected]>
muhabdulkadir
approved these changes
Sep 3, 2024
Signed-off-by: Jaskeerat Singh Saluja <[email protected]>
muhabdulkadir
suggested changes
Sep 3, 2024
Signed-off-by: Jaskeerat Singh Saluja <[email protected]>
muhabdulkadir
approved these changes
Sep 4, 2024
mttrbrts
approved these changes
Sep 4, 2024
mttrbrts
dismissed
ekarademir’s stale review
Feedback addressed. Snapshots have been updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #114
This PR would support the codegen for CSharp
This PR depends uses the API which is recently added to the concerto-core via PR accordproject/concerto#890 . Once this PR is merged to concerto-core the current Pr would be functional.
Related PR
Author Checklist
--signoffoption of git commit.mainfromfork:branchname