feat(alias-import): Pr suggestions

Signed-off-by: Jaskeerat Singh Saluja <[email protected]>
accordproject · Sep 3, 2024 · c204762 · c204762
1 parent e238635
commit c204762
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/lib/codegen/fromcto/csharp/csharpvisitor.js b/lib/codegen/fromcto/csharp/csharpvisitor.js
@@ -384,7 +384,7 @@ class CSharpVisitor {
         } else if (!field.isPrimitive()) {
             let fqn = this.getDotNetNamespaceOfType(field.getFullyQualifiedTypeName(), field.getParent(), parameters);
             const modelFile = field.getModelFile();
-            if (modelFile?.isImportedType?.(fieldType)) {
+            if (modelFile?.isImportedType(fieldType)) {
                 fieldType = modelFile.getImportedType(fieldType);
             }
             fieldType = `${fqn}${fieldType}`;

diff --git a/lib/codegen/fromcto/java/javavisitor.js b/lib/codegen/fromcto/java/javavisitor.js
@@ -270,7 +270,7 @@ class JavaVisitor {
         let fieldType = field.getType();
         if (!ModelUtil.isPrimitiveType(fieldType)) {
             const modelFile = field.getModelFile();
-            if (modelFile?.isImportedType?.(fieldType)) {
+            if (modelFile?.isImportedType(fieldType)) {
                 fieldType = modelFile.getImportedType(fieldType);
             }
         }

diff --git a/test/codegen/fromcto/java/javavisitor.js b/test/codegen/fromcto/java/javavisitor.js
@@ -467,9 +467,10 @@ describe('JavaVisitor', function () {
 
             const mockField             = sinon.createStubInstance(Field);
             const getType               = sinon.stub();
+            const isImportedType        = sinon.stub();
 
             mockField.ast = { type: { name: 'Dummy Value'} };
-            mockField.getModelFile.returns({ getType: getType });
+            mockField.getModelFile.returns({ getType: getType, isImportedType: isImportedType });
 
             const mockMapDeclaration    = sinon.createStubInstance(MapDeclaration);
             const getKeyType            = sinon.stub();
@@ -481,6 +482,7 @@ describe('JavaVisitor', function () {
             getType.returns(mockMapDeclaration);
             getKeyType.returns('String');
             getValueType.returns('String');
+            isImportedType.returns(false);
             mockField.getName.returns('Map1');
             mockMapDeclaration.getName.returns('Map1');
             mockMapDeclaration.isMapDeclaration.returns(true);