Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure user can't add double item to playlist #820

Merged
merged 5 commits into from
Jul 14, 2022

Conversation

robbevp
Copy link
Member

@robbevp robbevp commented Jul 6, 2022

Fixes #819

This playlist fixes two things around double items in playlists:

  • The error returned by the api (see Return error when creating double playlist items api#352) is now translated and correctly displayed
  • The options that already contain the item are disabled. I've also added a message to explain the disabled state (This message is quite verbose, but I don't mind this)

Since the error should not occur that often anymore, I don't think it's a problem that it is shown in its usual place and not in the dialog.

Screenshot 2022-07-06 at 09 37 12

@robbevp robbevp added the bug Something isn't working label Jul 6, 2022
@robbevp robbevp requested a review from chvp July 6, 2022 07:44
@robbevp robbevp self-assigned this Jul 6, 2022
@robbevp robbevp requested a review from chvp July 9, 2022 07:24
@chvp chvp removed their request for review July 9, 2022 10:04
@robbevp robbevp requested a review from chvp July 13, 2022 12:05
@chvp chvp merged commit 149bd61 into main Jul 14, 2022
@chvp chvp deleted the fix/playlists-double-items branch July 14, 2022 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User should get feedback if playlist already contains item
2 participants