Return error when creating double playlist items #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new validation relies on the items to actually exist, otherwise the result of `items.collect(&:item_id)` would be `[nil, nil]`
robbevp
changed the title
robbevp
force-pushed
the
fix/error-double-item-playlists
branch
from
b9ad79c
to
96e4ff9
Compare
chvp
approved these changes
Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #351
Our current way of setting the
itemsthroughitem_idsrequired some changes to make sure that it runs after the full playlist is modified. I've left some comments to explain the behaviour for ourselves in the future.Matching PR in web will follow asap.