Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: custom http error component #2142

Merged
merged 3 commits into from
Nov 11, 2019
Merged

feature: custom http error component #2142

merged 3 commits into from
Nov 11, 2019

Conversation

mehmet-erim
Copy link
Contributor

  • Added destroy subject to custom HTTP error component
  • Refactored the error.handler.spec and error.component.spec

@mehmet-erim mehmet-erim added this to the 1.1 milestone Nov 11, 2019
@thediaval thediaval merged commit 1505632 into dev Nov 11, 2019
@thediaval thediaval deleted the feat/theme-shared/custom-error branch November 11, 2019 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thediaval thediaval thediaval approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@mehmet-erim @thediaval