Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abp error status page option #2097

Merged
merged 6 commits into from
Nov 12, 2019
Merged

Abp error status page option #2097

merged 6 commits into from
Nov 12, 2019

Conversation

yekalkan
Copy link
Member

@yekalkan yekalkan commented Nov 6, 2019

added AbpErrorPageOptions and moved "/error" page to a new controller

@yekalkan yekalkan added this to the 1.1 milestone Nov 6, 2019
@yekalkan yekalkan requested a review from hikalkan November 6, 2019 07:46
@hikalkan
Copy link
Member

hikalkan commented Nov 6, 2019

@mehmet-erim this should be done for Angular too.

mehmet-erim added a commit that referenced this pull request Nov 7, 2019
@hikalkan
Copy link
Member

Rename/Move:

ErrorPageUrls -> ErrorViewUrls
AbpErrorPageModel -> AbpErrorViewModel
framework/src/Volo.Abp.AspNetCore.Mvc.UI.Theme.Shared/Pages/Error/Default.cshtml -> Views

@yekalkan yekalkan merged commit 3c444eb into dev Nov 12, 2019
@maliming maliming deleted the Abp-Error-status-Page-option branch November 14, 2019 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants