Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/theme shared/custom error #2119

Merged
merged 6 commits into from
Nov 7, 2019
Merged

Feat/theme shared/custom error #2119

merged 6 commits into from
Nov 7, 2019

Conversation

mehmet-erim
Copy link
Contributor

@mehmet-erim mehmet-erim commented Nov 7, 2019 •
edited
Loading

HTTP error token added to ThemeSharedModule to show the custom error component.
ErrorComponent improved
#2097

@mehmet-erim mehmet-erim added this to the 1.1 milestone Nov 7, 2019
@mehmet-erim mehmet-erim requested a review from thediaval November 7, 2019 13:06
@thediaval thediaval merged commit fbc8c57 into dev Nov 7, 2019
@thediaval thediaval deleted the feat/theme-shared/custom-error branch November 7, 2019 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thediaval thediaval thediaval approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@mehmet-erim @thediaval