Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve "Table" View names #268

Closed
mjherzog opened this issue Jul 20, 2018 · 1 comment
Closed

Improve "Table" View names #268

mjherzog opened this issue Jul 20, 2018 · 1 comment
Assignees
Milestone

Comments

@mjherzog
Copy link
Member

The current (version 2.4.1) Table View name is somewhat confusing because the current Component Summary View is also a table view. We should consider:

  • Renaming current Table View to something like ScanData View to emphasize what you will see in this table view.
  • Renaming Conclusion Summary View to Conclusions View to emphasize that what you see in this table is different from the Scan Data. This will also help with other terminology since the Conclusion data may represent a "Component" or a "Package".
@steven-esser steven-esser added this to the v2.5.0 milestone Jul 24, 2018
@steven-esser steven-esser modified the milestones: v2.5.0, v2.6.0 Aug 13, 2018
steven-esser added a commit that referenced this issue Aug 31, 2018
* Change varible/class/ids in main.css
* Change varible naming in aboutCodeBarChart.js
* Change varible naming in aboutCodeDashboard.js
* Change varible naming in aboutCodeJsTree.js
* Change varible naming in renderer.js
* Change varible/class/ids in index.html
* Change aboutCodeClueDataTable.js to aboutCodeScanDataDataTable.js

Signed-off-by: Steven Esser <[email protected]>
steven-esser added a commit that referenced this issue Aug 31, 2018
* update model on backend/DB side
* update css id/classes in view files

Signed-off-by: Steven Esser <[email protected]>
@steven-esser
Copy link
Contributor

Merged #296, closing this.

steven-esser added a commit that referenced this issue Sep 25, 2018
* Change varible/class/ids in main.css
* Change varible naming in aboutCodeBarChart.js
* Change varible naming in aboutCodeDashboard.js
* Change varible naming in aboutCodeJsTree.js
* Change varible naming in renderer.js
* Change varible/class/ids in index.html
* Change aboutCodeClueDataTable.js to aboutCodeScanDataDataTable.js

Signed-off-by: Steven Esser <[email protected]>
steven-esser added a commit that referenced this issue Sep 25, 2018
* update model on backend/DB side
* update css id/classes in view files

Signed-off-by: Steven Esser <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants