Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Tree View in other views #267

Closed
mjherzog opened this issue Jul 20, 2018 · 2 comments
Closed

Show Tree View in other views #267

mjherzog opened this issue Jul 20, 2018 · 2 comments

Comments

@mjherzog
Copy link
Member

mjherzog commented Jul 20, 2018

With current version 2.4.1 the TreeView is shown on the left for the Chart Summary View and the Table View, but not for the Dashboard View or Component Summary View. It makes sense to offer the Tree View on the left for all Views since the Tree View shows you the codebase you are working with and it is the easiest way to navigate files and directories. This will also allow you to "keep your place" relative to the codebase as you move among directories and files which is already the case for the Table and Chart Summary Views.

The specific enhancement is to add the Tree View for the Dashboard and Component Summary Views with the same navigation approach as the Table View - i.e the window on the right will show you data related to your current selection in the Tree View

This issue does not deal with the Edit Component window, but an assumption for simplicity could be that you can invoke Edit Component from the Tree View regardless of which other View that is on the right. It is probably not very useful to Edit Component from the Chart Summary View (or Dashboard View) but not clear that it would cause any harm.

See also #268 for some View naming changes that will likely apply before this enhancement.

@johnmhoran
Copy link
Member

@mjherzog See also issue #128 (add links in Component Summary View) (and note one of Jillian's comments: "In particular, we add an onClick to the html element surround the text. As a side note, we might want to consider having the jsTree displayed in all of the views. This might mitigate part of the problem.").

@steven-esser steven-esser added this to the Future milestone Jul 24, 2018
@steven-esser steven-esser modified the milestones: Future, v2.6.1 Sep 24, 2018
steven-esser added a commit that referenced this issue Sep 25, 2018
* Update Dashboard chart data queries to match with current selected path
* Calculate files_count based on selected path #267

Signed-off-by: Steven Esser <[email protected]>
steven-esser added a commit that referenced this issue Sep 25, 2018
* Dashboard d3 charts update depending on selected path
* File Counts update depening on selected path

Addresses: #267

Signed-off-by: Steven Esser <[email protected]>
steven-esser added a commit that referenced this issue Sep 26, 2018
* Dashboard d3 charts update depending on selected path
* File Counts update depending on selected path
* Unique License and Copyright counts now filtered by selected path
* Package counts now filtered by selected path

Addresses: #267

Signed-off-by: Steven Esser <[email protected]>
steven-esser added a commit that referenced this issue Oct 2, 2018
* Dashboard d3 charts update depending on selected path
* File Counts update depending on selected path
* Unique License and Copyright counts now filtered by selected path
* Package counts now filtered by selected path
* Update file counts in BarChart view

Addresses: #267

Signed-off-by: Steven Esser <[email protected]>
steven-esser added a commit that referenced this issue Oct 2, 2018
* Dashboard d3 charts update depending on selected path
* File Counts update depending on selected path
* Unique License and Copyright counts now filtered by selected path
* Package counts now filtered by selected path
* Update file counts in BarChart view
* Add TreeView support to Conclusions table

Addresses: #267

Signed-off-by: Steven Esser <[email protected]>
@steven-esser
Copy link
Contributor

#305 merged, closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants