Replaced DeviceDetails with the LocalDevice
#188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e is a typo. So I don't use the spec modification procedure here ("This clause has been deleted. It was valid up to...") and just editing the current version.
maratal
force-pushed
the
fix/187-erroneous-device-details-ref
branch
from
db81f85 to
d38cb65
Compare
ttypic
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think mentioning "local DeviceDetails" instead of "LocalDevice" here is a typo. So I don't use the spec modification procedure here ("This clause has been deleted. It was valid up to...") and just editing the current version.. Correct me if it should be a proper spec replacement.
I've avoided to replace all mentions of "local DeviceDetails" to "LocalDevice", since in places where
deviceSecretis not used it's not important.