Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spec erroneously refers (RSH3a2a, RSH3b3) to "local DeviceDetails" #187

Closed
maratal opened this issue Mar 24, 2024 · 0 comments · Fixed by #188
Closed

Spec erroneously refers (RSH3a2a, RSH3b3) to "local DeviceDetails" #187

maratal opened this issue Mar 24, 2024 · 0 comments · Fixed by #188

Comments

@maratal
Copy link
Collaborator

maratal commented Mar 24, 2024 •
edited
Loading

There should be RSH3a2b1 describing POST /push/deviceRegistrations similar to PUT in RSH3a2a3.
RSH3b3a describes that.

Spec erroneously refers (RSH3a2a, RSH3b3b) to "local DeviceDetails" which should be "LocalDevice details" instead (which I guess led to the error in ably-cocoa implementation).

Also docs are needed to be updated too to include device secret.
@maratal maratal mentioned this issue Mar 24, 2024
Closed
@maratal maratal changed the title Update RSH3a2b and add spec describing POST /push/deviceRegistrations Spec erroneously refers (RSH3a2a, RSH3b3) to "local DeviceDetails" Mar 31, 2024
@maratal maratal linked a pull request Mar 31, 2024 that will close this issue
Replaced DeviceDetails with the LocalDevice #188
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replaced DeviceDetails with the LocalDevice ably/specification
1 participant
@maratal