Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Device registration flow omits deviceSecret (both in code and documentation) #1892

Closed
maratal opened this issue Mar 24, 2024 · 0 comments · Fixed by #1893
Closed

Device registration flow omits deviceSecret (both in code and documentation) #1892

maratal opened this issue Mar 24, 2024 · 0 comments · Fixed by #1893
Assignees

Comments

@maratal
Copy link
Collaborator

maratal commented Mar 24, 2024

It was not necessary in protocol v1 for some reason. In protocol v2 this requirement was loosen for admin registrations (internal discussion) and never was added as a part of normal registration flow, since the docs wasn't reflecting this:

(RSH3a2b) If the local device does not have id or deviceSecret, both are generated locally. The id must be a unique identifier (e.g. UUID, GUID). The deviceSecret must be created using secure random data with sufficient entropy to generate a digest of at least 32 bytes (eg using sha256) and encoding that digest with base64. The local DeviceDetails is updated with the resulting deviceId and deviceSecret. If either the id or the deviceSecret is lost then a new pair must be created.

There should be RSH3a2b1 describing POST /push/deviceRegistrations similar to PUT in RSH3a2a3. Also spec erronously refers to "local DeviceDetails" which should be "LocalDevice details" instead. Issue in spec repo.

Needs updating RSH3b3 as well.

┆Issue is synchronized with this Jira Task by Unito

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant