Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis enhancements #276

Merged
merged 7 commits into from
Mar 4, 2016
Merged

Travis enhancements #276

merged 7 commits into from
Mar 4, 2016

Conversation

ricardopereira
Copy link
Contributor

No description provided.

@ricardopereira
Copy link
Contributor Author

I did a little optimisation. If the first test target fails then it will stop the test suite immediately.
@mattheworiordan @tcard PTAL. I want to merge this.

@mattheworiordan
Copy link
Member

I want to merge this.

And I'm watching the build :)

@ricardopereira
Copy link
Contributor Author

Unfortunately, the log will only update in the end of the execution 😞 but at least the test suite will be more stable... I hope so 😁

@ricardopereira
Copy link
Contributor Author

The AblySpec target failed and the AblyTests didn't start 👍
@mattheworiordan Can I run the test again and see if it passes?

@tcard
Copy link
Contributor

tcard commented Mar 4, 2016

I'm not sure this is a good idea. I want to know all the tests I'm breaking so that I can fix all of them.

@ricardopereira
Copy link
Contributor Author

@tcard But it takes time and you will know all the failing tests from the current test target.

@ricardopereira
Copy link
Contributor Author

I'm not sure this is a good idea. I want to know all the tests I'm breaking so that I can fix all of them.

@tcard But it takes time and you will know all the failing tests from the current test target.

@mattheworiordan What is your opinion about this?

@mattheworiordan
Copy link
Member

But it takes time and you will know all the failing tests from the current test target.

What is your opinion about this?

I am not sure I understand the problem. Are you saying we don't get the list of broken tests in the output? Generally, I prefer for a build not to abort and run all tests so that when you get the feedback, you can go through all broken tests, fix them and rebuild. If we abort a test early, won't it then prevent this? Why was 81eca60 needed?

@ricardopereira
Copy link
Contributor Author

@mattheworiordan We have two steps: AblySpec (Swift) and AblyTests (ObjC). I did 81eca60 in case of one of the steps fails, the test suite stops immediately and is marked as errored. It will show all the broken tests about the current step.

@ricardopereira
Copy link
Contributor Author

Sorry, I didn't mention why I did it. Well, I thought it would be nice to abort the test suite immediately if one of the steps fails to win time but maybe it makes more sense to have a clear idea on what it's failing.

@ricardopereira
Copy link
Contributor Author

Ok, I will undo 81eca60.

@ricardopereira
Copy link
Contributor Author

I decided to do a new commit to maintain the old ones in the history. Could be helpful for something else.

@ricardopereira ricardopereira changed the title Travis: run each test target independently Travis enhancements Mar 4, 2016
@ricardopereira
Copy link
Contributor Author

@mattheworiordan @tcard Can I merge?

@tcard
Copy link
Contributor

tcard commented Mar 4, 2016

Yes, LGTM.

ricardopereira added a commit that referenced this pull request Mar 4, 2016
@ricardopereira ricardopereira merged commit 108ab09 into master Mar 4, 2016
@ricardopereira ricardopereira deleted the fix-travis-tests branch March 4, 2016 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants