-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Travis enhancements #276
Travis enhancements #276
Conversation
I did a little optimisation. If the first test target fails then it will stop the test suite immediately. |
And I'm watching the build :) |
Unfortunately, the log will only update in the end of the execution 😞 but at least the test suite will be more stable... I hope so 😁 |
The |
I'm not sure this is a good idea. I want to know all the tests I'm breaking so that I can fix all of them. |
@tcard But it takes time and you will know all the failing tests from the current test target. |
@mattheworiordan What is your opinion about this? |
I am not sure I understand the problem. Are you saying we don't get the list of broken tests in the output? Generally, I prefer for a build not to abort and run all tests so that when you get the feedback, you can go through all broken tests, fix them and rebuild. If we abort a test early, won't it then prevent this? Why was 81eca60 needed? |
@mattheworiordan We have two steps: |
Sorry, I didn't mention why I did it. Well, I thought it would be nice to abort the test suite immediately if one of the steps fails to win time but maybe it makes more sense to have a clear idea on what it's failing. |
Ok, I will undo 81eca60. |
I decided to do a new commit to maintain the old ones in the history. Could be helpful for something else. |
@mattheworiordan @tcard Can I merge? |
Yes, LGTM. |
No description provided.