Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove block typedefs, use block syntax explicitly. #275

Merged
merged 9 commits into from
Mar 4, 2016

Conversation

tcard
Copy link
Contributor

@tcard tcard commented Mar 3, 2016

Typedefs for block types are pretty annoying, because when checking how you should call some method that takes a callback you then need also to check the signature of the callback type. Now it's all inlined and explicit, if more verbose.

@ricardopereira
Copy link
Contributor

Awesome 👍

@ricardopereira ricardopereira force-pushed the remove-block-typedefs branch from 142a6f9 to 356ab25 Compare March 4, 2016 08:17
@mattheworiordan
Copy link
Member

Ok, looks good. I suppose there is an argument that sharing types could be useful, but I expect in reality, this is not the case an inlining it like this helps developers. Nice one @tcard

@ricardopereira
Copy link
Contributor

I think it's a known bug from Xcode but for now it's better so. It's quite annoying to select one method from code completion and then you need to check the list of arguments for a block. Great one.

@ricardopereira
Copy link
Contributor

Need a rebase after #276

@tcard tcard force-pushed the remove-block-typedefs branch from 356ab25 to fcdaf73 Compare March 4, 2016 16:20
@ricardopereira ricardopereira force-pushed the remove-block-typedefs branch from fcdaf73 to 3bea16b Compare March 4, 2016 16:40
ricardopereira added a commit that referenced this pull request Mar 4, 2016
Remove block typedefs, use block syntax explicitly.
@ricardopereira ricardopereira merged commit 2398b95 into master Mar 4, 2016
@ricardopereira ricardopereira deleted the remove-block-typedefs branch March 4, 2016 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants