-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove block typedefs, use block syntax explicitly. #275
Conversation
Awesome 👍 |
142a6f9
to
356ab25
Compare
Ok, looks good. I suppose there is an argument that sharing types could be useful, but I expect in reality, this is not the case an inlining it like this helps developers. Nice one @tcard |
I think it's a known bug from Xcode but for now it's better so. It's quite annoying to select one method from code completion and then you need to check the list of arguments for a block. Great one. |
Need a rebase after #276 |
356ab25
to
fcdaf73
Compare
fcdaf73
to
3bea16b
Compare
Remove block typedefs, use block syntax explicitly.
Typedefs for block types are pretty annoying, because when checking how you should call some method that takes a callback you then need also to check the signature of the callback type. Now it's all inlined and explicit, if more verbose.