Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transition to Xcode 15.1 #1851

Merged
merged 4 commits into from
Jan 17, 2024
Merged

Transition to Xcode 15.1 #1851

merged 4 commits into from
Jan 17, 2024

Conversation

maratal
Copy link
Collaborator

@maratal maratal commented Jan 7, 2024 •
edited
Loading

On top of #1840

@maratal maratal marked this pull request as draft January 7, 2024 15:16
@github-actions github-actions bot temporarily deployed to staging/pull/1851/features January 7, 2024 15:16 Inactive
@maratal maratal changed the base branch from main to fix/1311-single-workflow January 7, 2024 15:18
@github-actions github-actions bot temporarily deployed to staging/pull/1851/jazzydoc January 7, 2024 15:21 Inactive
@maratal maratal force-pushed the fix/1796-transition-to-xcode-15-1 branch from 4351cf4 to f75baab Compare January 7, 2024 15:27
@github-actions github-actions bot temporarily deployed to staging/pull/1851/features January 7, 2024 15:27 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1851/jazzydoc January 7, 2024 15:33 Inactive
@maratal maratal force-pushed the fix/1796-transition-to-xcode-15-1 branch from f75baab to 9a1bc6c Compare January 7, 2024 15:59
@github-actions github-actions bot temporarily deployed to staging/pull/1851/features January 7, 2024 15:59 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1851/jazzydoc January 7, 2024 16:03 Inactive
@maratal maratal force-pushed the fix/1796-transition-to-xcode-15-1 branch from 9a1bc6c to 8fffb97 Compare January 7, 2024 17:46
@github-actions github-actions bot temporarily deployed to staging/pull/1851/features January 7, 2024 17:47 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1851/jazzydoc January 7, 2024 17:50 Inactive
@maratal maratal marked this pull request as ready for review January 7, 2024 20:32
lawrence-forooghian
lawrence-forooghian reviewed Jan 8, 2024
View reviewed changes
Copy link
Collaborator

@lawrence-forooghian lawrence-forooghian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't just "transition to Xcode 15.1", right? It's also changing the platform versions on which we test in CI. If so, we need to update the corresponding information in the README.

fastlane/Fastfile Outdated Show resolved Hide resolved
Base automatically changed from fix/1311-single-workflow to main January 10, 2024 12:22
@github-actions github-actions bot temporarily deployed to staging/pull/1851/features January 10, 2024 23:24 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1851/jazzydoc January 10, 2024 23:28 Inactive
@maratal
Copy link
Collaborator Author

maratal commented Jan 12, 2024

This isn't just "transition to Xcode 15.1", right? It's also changing the platform versions on which we test in CI. If so, we need to update the corresponding information in the README.

done - 695e8f6

@maratal maratal merged commit eda7a54 into main Jan 17, 2024
7 checks passed
@maratal maratal deleted the fix/1796-transition-to-xcode-15-1 branch January 17, 2024 17:36
@maratal maratal mentioned this pull request Jan 19, 2024
Closed
This was referenced Feb 5, 2024
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lawrence-forooghian lawrence-forooghian lawrence-forooghian approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maratal @lawrence-forooghian