-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK-1683] Single workflow with matrix strategy #1840
Conversation
7f70719
to
70a06b7
Compare
70a06b7
to
38d31c1
Compare
38d31c1
to
3e5606e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something that I noticed is that there is now no way to tell which OS an observability server upload corresponds to. Compare the following:
Notice that in the first one, clicking the "GitHub run ID" or "GitHub run attempt" link takes you to the iOS job. In the second, it takes you to an overview page that shows all 3 OSs.
There is probably some other piece of data that we need to get from the environment and include in the upload to the observability server to allow it to display a link to the correct job.
Turned out it's not trivial. |
I think we need to do that then. Sounds like the steps are the following:
|
I've actually just needed to do the same thing for ably-js. Here's the PR for adding this functionality to the upload; it should help you here. ably/test-observability-action#20 |
I've implemented it for ably-cocoa in #1845. You'll just need to pass the |
This is wonderful, thanks Lawrence! |
# Conflicts: # .github/workflows/integration-test-iOS16_2.yaml # .github/workflows/integration-test-tvOS16_1.yaml
989feaf
to
491aa20
Compare
491aa20
to
528342d
Compare
528342d
to
6bd3ea8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good — let's not merge this until ably/test-observability#76 is merged and deployed though.
This is now deployed. |
Re-running CI to check that the URL gets correctly populated in observability server. If it does, I'll approve. |
Closes #1311