Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clientId mismatch on login #38

Merged
merged 15 commits into from
Jul 15, 2024
Merged

Fix clientId mismatch on login #38

merged 15 commits into from
Jul 15, 2024

Commits on Jul 9, 2024

  1. Set MockAuthServer clientId as string or null, updated tests to inclu… 

    …de clientId
    @sacOO7
    sacOO7 committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    a49b8c8 View commit details
    Browse the repository at this point in the history

  2. Added callback method onClientIdChanged on AblyConnector

    @sacOO7
    sacOO7 committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    f6a747f View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2024

  1. Refactored ablyauth code, added authorization before channel attach

    @sacOO7
    sacOO7 committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    22d4be2 View commit details
    Browse the repository at this point in the history

  2. Added separate test for ably-user-login

    @sacOO7
    sacOO7 committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    dc56684 View commit details
    Browse the repository at this point in the history

  3. Following changes are made 

    1.Moved onClientIdChanged method to auth
2.Added method allowReconnectOnUserLogin that tracks failed connection state due to
user login and calls onClientIdChanged. It is initilized in ablyConnector.
3.Updated onClientIdChanged implementation to reconnect on existing client and
re-attach failed channels
    @sacOO7
    sacOO7 committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    c40adb4 View commit details
    Browse the repository at this point in the history

  4. Updated ably-user-login test to validate user success for channel with 

    new clientId
    @sacOO7
    sacOO7 committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    e822032 View commit details
    Browse the repository at this point in the history

  5. Updated onClientIdChanges, only attach public channels after connect

    @sacOO7
    sacOO7 committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    d385699 View commit details
    Browse the repository at this point in the history

  6. Updated implementation for allowReconnectOnUserLogin, connectionFaile… 

    …dCallback

will be executed only once for clientId change
    @sacOO7
    sacOO7 committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    faf7a7c View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2024

  1. Updated tests for ably_user-login, user login and user logout

    @sacOO7
    sacOO7 committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    5d46ab6 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2024

  1. Fixed channelAuthorize bug 

    1. Sets passed authorize implementation as a channel property
2. Same property will be reused for auth on next Echo instance
    @sacOO7
    sacOO7 committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    30b6226 View commit details
    Browse the repository at this point in the history

  2. Updated onClientId changed impl, enable attach for all existing channels

    @sacOO7
    sacOO7 committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    1b5b661 View commit details
    Browse the repository at this point in the history

  3. Updated ably-user-login tests, added more assertions for channel errors

    @sacOO7
    sacOO7 committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    3823f94 View commit details
    Browse the repository at this point in the history

  4. Revert "Set MockAuthServer clientId as string or null, updated tests … 

    …to include clientId"

This reverts commit a49b8c8.
    @sacOO7
    sacOO7 committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    8c68162 View commit details
    Browse the repository at this point in the history

  5. Refactored user-login-tests, added more comments for better understan… 

    …ding
    @sacOO7
    sacOO7 committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    8bec647 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2024

  1. Removed scheduled cron job from tests.yml

    @sacOO7
    sacOO7 committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    4e082f2 View commit details
    Browse the repository at this point in the history