Fix clientId mismatch on login #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1.Moved onClientIdChanged method to auth 2.Added method allowReconnectOnUserLogin that tracks failed connection state due to user login and calls onClientIdChanged. It is initilized in ablyConnector. 3.Updated onClientIdChanged implementation to reconnect on existing client and re-attach failed channels
…dCallback will be executed only once for clientId change
1. Sets passed authorize implementation as a channel property 2. Same property will be reused for auth on next Echo instance
…to include clientId" This reverts commit a49b8c8.
ttypic
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If multiple instances of
echoused in same app, it would cause new instance to useauthorizesupplied by first instance.