This repository has been archived by the owner on Mar 21, 2018. It is now read-only.
Keyboard Accessibility #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Giving carousels tabindex of zero to allow them to be focused. Listening for up, down, left and right to progress the sliders. e.preventDefault() doesn't seem to be stopping the web page from scrolling. Need to look into this.
Fixes an issue where the page scrolled on key presses, despite the fact that the carousel had focus.
Left/right keys will work on horizontal carousels, up/down on vertical. All keys will work on class-only carousels. Additionally, since touch_lock_* are now used to implement this functionality, I've renamed them to lock_*, and simplified the case statements into if/else blocks.
For keyboard users, this is the equivalent of mouseenter/mouseleave.
abitgone
added a commit
that referenced
this pull request
Oct 22, 2012
…bility Implement Keyboard Accessibility
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements keyboard accessibility, as requested by @mattmachel in issue #2, with the following features: