namespaced storage #22
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
miguelmtzinf
reviewed
Jan 2, 2025
| address internal s_rateLimitAdmin; | ||
|
|
||
| /// @custom:storage-location erc7201:aave-ccip.storage.UpgradeableTokenPool | ||
| struct UpgradeableTokenPoolStorage { |
There was a problem hiding this comment.
are not all of this part of TokenPool storage layout? so we don't need this
There was a problem hiding this comment.
this is the storage for this contract tho, i'm not sure i follow
(we don't inherit from TokenPool in UpgradeableTokenPool, we copy paste and add modifications on top)
miguelmtzinf
reviewed
Jan 2, 2025
| /// @custom:storage-location erc7201:aave-ccip.storage.UpgradeableLockReleaseTokenPool | ||
| struct UpgradeableLockReleaseTokenPoolStorage { | ||
| /// @notice The address of the rebalancer. | ||
| address s_rebalancer; |
|
Closing, as we are leaning towards using an storage gap (included in #20) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
erc7201 style storage layout