Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCIP 1.5.1 #20

Merged
merged 29 commits into from
Jan 2, 2025
Merged

CCIP 1.5.1 #20

merged 29 commits into from
Jan 2, 2025

Conversation

DhairyaSethi
Copy link
Member

@DhairyaSethi DhairyaSethi commented Dec 5, 2024

GHO CCIP 1.5.1

Channelog from 1.5 -> 1.5.1
Changes from CCIP 1.4

GHO Token Pools modifications on top of CCIP 1.5.1 -> Same as the changes on CCIP 1.4 in ccip-gho, also mentioned in comments on the token pool contracts except:

  • UpgradeableTokenPool
    • Remove i_token decimal() check in constructor.
    • Add storage __gap.
  • UpgradeableBurnMintTokenPool
    • RateLimit Admin functionality is moved to TokenPool & hence not needed to be set here.
    • Add GHO-Specific onlyOwner directMint which mints liquidity to the old pool & increases facilitator level.
    • Add GHO-Specific onlyOwner directBurn which burns liquidity & reduces facilitator level.
  • UpgradeableLockReleaseTokenPool
    • Introduce s_bridgedAmount permissioned setter, expected to be called while migrating token pools with transferLiquidity, added for flexibility.

Certora Formal Verification suite changes:

  • Update solidity versions to 0.8.24 from 0.8.19 (CCIP profile was updated to this target with 1.5)
  • Use latest certora cli version in CI -> 7.20.3 from 7.17.2
  • Modify ccip.conf: Add optimistic_hashing to true. This was added because with 1.5.1, multiple remotePoolAddresses are stored and checked against in _validatorLockOrBurn, this being an unbounded array needs to accounted for in Certora as expected functionality. See more information on unbounded hashing. Failed run without this setting here.
  • Invariants modified
    • currentBridge_LEQ_bridgeLimit => filter function selector check for the new setCurrentBridgedAmount in addition to existing filter for setBridgeLimit
  • Rules modified
    • only_lockOrBurn_can_increase_currentBridged => filter function selector check for the new setCurrentBridgedAmount
    • only_releaseOrMint_can_decrease_currentBridged => filter function selector check for the new setCurrentBridgedAmount
  • New Rule added: only_owner_can_call_setCurrentBridgedAmount

Copy link

height bot commented Dec 5, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@miguelmtzinf miguelmtzinf self-requested a review December 24, 2024 19:43
Base automatically changed from ccip-develop to ccip_gho January 2, 2025 11:47
@miguelmtzinf miguelmtzinf mentioned this pull request Jan 2, 2025
@nisnislevi
Copy link

This PR was verified by Certora team. No bugs or issues were found.

@miguelmtzinf miguelmtzinf merged commit 49caffa into ccip-gho Jan 2, 2025
2 checks passed
@miguelmtzinf miguelmtzinf deleted the feat/1_5_1_token_pool branch January 2, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants