forked from smartcontractkit/ccip
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CCIP 1.5.1 #20
Merged
Merged
CCIP 1.5.1 #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closed
contracts/src/v0.8/ccip/test/pools/GHO/GhoTokenPoolRemote.t.sol
Outdated
Show resolved
Hide resolved
miguelmtzinf
reviewed
Dec 9, 2024
contracts/src/v0.8/ccip/pools/GHO/UpgradeableBurnMintTokenPool.sol
Outdated
Show resolved
Hide resolved
contracts/src/v0.8/ccip/pools/GHO/UpgradeableLockReleaseTokenPool.sol
Outdated
Show resolved
Hide resolved
contracts/src/v0.8/ccip/pools/GHO/UpgradeableLockReleaseTokenPool.sol
Outdated
Show resolved
Hide resolved
contracts/src/v0.8/ccip/pools/GHO/UpgradeableLockReleaseTokenPool.sol
Outdated
Show resolved
Hide resolved
…er,provide,withdraw}Liquidity
contracts/src/v0.8/ccip/test/pools/GHO/GhoTokenPoolRemote.t.sol
Outdated
Show resolved
Hide resolved
contracts/src/v0.8/ccip/test/pools/GHO/invariant/GhoTokenPoolHandler.t.sol
Show resolved
Hide resolved
contracts/src/v0.8/ccip/test/pools/GHO/GhoTokenPoolEthereum.t.sol
Outdated
Show resolved
Hide resolved
contracts/src/v0.8/ccip/test/pools/GHO/GhoTokenPoolRemote.t.sol
Outdated
Show resolved
Hide resolved
miguelmtzinf
approved these changes
Dec 24, 2024
miguelmtzinf
reviewed
Jan 2, 2025
contracts/src/v0.8/ccip/pools/GHO/UpgradeableLockReleaseTokenPool.sol
Outdated
Show resolved
Hide resolved
miguelmtzinf
reviewed
Jan 2, 2025
contracts/src/v0.8/ccip/pools/GHO/UpgradeableBurnMintTokenPool.sol
Outdated
Show resolved
Hide resolved
Closed
This PR was verified by Certora team. No bugs or issues were found. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GHO CCIP 1.5.1
Channelog from 1.5 -> 1.5.1
Changes from CCIP 1.4
GHO Token Pools modifications on top of CCIP 1.5.1 -> Same as the changes on CCIP 1.4 in
ccip-gho
, also mentioned in comments on the token pool contracts except:i_token
decimal() check in constructor.__gap
.directMint
which mints liquidity to the old pool & increases facilitator level.directBurn
which burns liquidity & reduces facilitator level.s_bridgedAmount
permissioned setter, expected to be called while migrating token pools withtransferLiquidity
, added for flexibility.Certora Formal Verification suite changes:
optimistic_hashing
to true. This was added because with 1.5.1, multiple remotePoolAddresses are stored and checked against in_validatorLockOrBurn
, this being an unbounded array needs to accounted for in Certora as expected functionality. See more information on unbounded hashing. Failed run without this setting here.currentBridge_LEQ_bridgeLimit
=> filter function selector check for the newsetCurrentBridgedAmount
in addition to existing filter forsetBridgeLimit
only_lockOrBurn_can_increase_currentBridged
=> filter function selector check for the newsetCurrentBridgedAmount
only_releaseOrMint_can_decrease_currentBridged
=> filter function selector check for the newsetCurrentBridgedAmount
only_owner_can_call_setCurrentBridgedAmount