Improve PHP 8.x linting #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PHPCompatibilityWP package is tied to the 9.x release of the PHPCompatibility package. The current 9.3.5 release of PHPCompatibility has not been updated since December 2019 and I believe is missing quite a few updated sniffs for PHP 8.x syntax. See: PHPCompatibility/PHPCompatibility@9.3.5...develop This labels the PHPCompatibility `develop` branch as a 9.99.99 release, which satisifies the PHPCompatibilityWP requirements and improves scanning for PHP 8.x compatibility. See: PHPCompatibility/PHPCompatibilityWP#40 (comment) Changes: * `composer config minimum-stability dev` * `composer require --dev phpcompatibility/php-compatibility:"dev-develop as 9.99.99"` * `composer update phpcompatibility/phpcompatibility-wp`
|
There's a chance |
|
The project is still actively worked on although there really hasn't been a new release in 5 years. Is this being solved some other way or is this still an issue ~1.5 years later? 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PHPCompatibilityWP package is tied to the 9.x release of the PHPCompatibility package.
The current 9.3.5 release of PHPCompatibility has not been updated since December 2019 and I believe is missing quite a few updated sniffs for PHP 8.x syntax.
See: PHPCompatibility/PHPCompatibility@9.3.5...develop
This change labels the PHPCompatibility
developbranch as a 9.99.99 release, which satisifies the PHPCompatibilityWP requirements and improves scanning for PHP 8.x compatibility. This is the method recommended on the PHPCompatibilityWP repository.Changes:
composer config minimum-stability devcomposer require --dev phpcompatibility/php-compatibility:"dev-develop as 9.99.99"composer update phpcompatibility/phpcompatibility-wp