Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow use of PHPCompatibilty:dev-develop #40

Closed
GaryJones opened this issue May 27, 2022 · 4 comments
Closed

Allow use of PHPCompatibilty:dev-develop #40

GaryJones opened this issue May 27, 2022 · 4 comments
Labels
question

Comments

@GaryJones
Copy link
Collaborator

Installing the master branch / latest release of PHPCompatibilityWP will use PHPCompatibility ^9.0.

It would be useful to be able to install a (temporary) version of PHPCompatibilityWP that would use the dev-develop branch of PHPComapatibility, so that sniffs with some PHP 8 focus can be used.

What's the best way of providing that?
(Either as a new branch here, or instructions in the readme on how users can adapt their project / global install)
@jrfnl
Copy link
Member

jrfnl commented May 27, 2022

@GaryJones I have a feeling I already answered this for you before ?

Either way, the answer hasn't changed:

composer config minimum-stability dev
composer require --dev phpcompatibility/php-compatibilitywp
composer require --dev phpcompatibility/php-compatibility:"dev-develop as 9.99.99"

The dev-develop as 9.99.99 aliases the develop branch of PHPCompatibility to a 9.x version which is within the allowed range for PHPCompatibilityWP.

We ourselves use the same principle to already run the tests against PHPCompatibility dev-develop:

Note: once PHPCompatibility 10.0.0 has come out, this repo will get a 3.0.0 release based on PHPCompatibility 10.0.0.

@jrfnl jrfnl added the question label May 27, 2022
@jrfnl jrfnl removed their assignment May 27, 2022
@GaryJones
Copy link
Collaborator Author

I thought you had too, but I couldn't remember it :-)

Thank you!

@jrfnl
Copy link
Member

jrfnl commented Jun 5, 2022 •
edited by GaryJones
Loading

@GaryJones No worries.

@jrfnl jrfnl pinned this issue Jun 10, 2022
@kasparsd kasparsd mentioned this issue Oct 7, 2022
Merged
jeremyfelt added a commit to jeremyfelt/team51-configs that referenced this issue Aug 4, 2023
@jeremyfelt
Improve PHP 8.x linting
bcfcc55 
The PHPCompatibilityWP package is tied to the 9.x release of the
PHPCompatibility package.

The current 9.3.5 release of PHPCompatibility has not been updated
since December 2019 and I believe is missing quite a few updated
sniffs for PHP 8.x syntax.

See: PHPCompatibility/PHPCompatibility@9.3.5...develop

This labels the PHPCompatibility `develop` branch as a 9.99.99
release, which satisifies the PHPCompatibilityWP requirements and
improves scanning for PHP 8.x compatibility.

See: PHPCompatibility/PHPCompatibilityWP#40 (comment)

Changes:
* `composer config minimum-stability dev`
* `composer require --dev
  phpcompatibility/php-compatibility:"dev-develop as 9.99.99"`
* `composer update phpcompatibility/phpcompatibility-wp`
@jeremyfelt jeremyfelt mentioned this issue Aug 4, 2023
Open
@jonathanbossenger jonathanbossenger mentioned this issue Oct 10, 2023
Open
@darylldoyle darylldoyle mentioned this issue Nov 15, 2023
Merged
@justlevine justlevine mentioned this issue Jan 3, 2024
Merged
@daankortenbach
Copy link

tnx, needed this, happy ny

@waviaei waviaei mentioned this issue Oct 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@GaryJones @jrfnl @daankortenbach