This repository has been archived by the owner on Jun 19, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 57
add memo and tx type indexing #97
Closed
+17
−2
Closed
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
e1718de
remove is default from vote_proposal
dimiandre 33d6235
try index memo
dimiandre 4d9b9c4
add code_type column for easy tx type index
dimiandre 147b6df
Merge branch 'Zondax:main' into kintsugi/index_memo
dimiandre ef527cb
Merge branch 'Zondax:main' into kintsugi/index_memo
dimiandre 4b9e0fe
Merge branch 'main' into kintsugi/index_memo
dimiandre 95cc863
Merge branch 'main' into kintsugi/index_memo
dimiandre fc4459b
merge
dimiandre 9dfa644
change wrapper to unknown
dimiandre File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is redundant with
tx_type
which already exist in the table. You want to indicate if the tx is decrypted or wrapper... etc, right ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to indicate what that decrypted tx actually contains
tx_transfer
tx_ibc
etc
otherwise there is no easy way to "decode" code and query it directly from the database
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ok. We use the
code
to indicate the tx_type but indeed you need to know it.So just change the default value
wrapper
withunknown
. Wrapper is another type (decrypted, wrapper, protocol,...) and it is different from what you want (aka tx_transfer, tx_ibc, ...). Just so we don't get mixed up.