add memo and tx type indexing #97
Conversation
|
there is also a commit on vote_proposal i forgot in previous pr, sorry! |
|
I need to fix the tests before accepting your PR. Just to be sure we are not breaking more things. |
|
The tests are fixed. You can rebase and I will run them on your PR. |
src/database.rs
Outdated
| @@ -599,7 +601,9 @@ impl Database { | |||
| for t in txs.iter() { | |||
| let tx = Tx::try_from(t.as_slice()).map_err(|_| Error::InvalidTxData)?; | |||
|
|
|||
| let mut code = Default::default(); | |||
| let mut code: [u8; 32] = Default::default(); | |||
| let mut code_type: String = "wrapper".to_string(); | |||
There was a problem hiding this comment.
I think this is redundant with tx_type which already exist in the table. You want to indicate if the tx is decrypted or wrapper... etc, right ?
There was a problem hiding this comment.
I'd like to indicate what that decrypted tx actually contains
tx_transfer
tx_ibc
etc
otherwise there is no easy way to "decode" code and query it directly from the database
There was a problem hiding this comment.
Ah ok. We use the code to indicate the tx_type but indeed you need to know it.
So just change the default value wrapper with unknown. Wrapper is another type (decrypted, wrapper, protocol,...) and it is different from what you want (aka tx_transfer, tx_ibc, ...). Just so we don't get mixed up.
|
Hi @dimiandre If you want me to merge this, could you replace "wrapper" with "unknown" ? I think others will find it useful. |
|
Hey @dimiandre I am sorry. There is some cnflicts do you think you can solve them ? I can't merge it |
add memo and tx type indexing for easy queries