Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate test suite to Pytest #164

Closed
ZeroIntensity opened this issue May 5, 2024 · 9 comments
Closed

Migrate test suite to Pytest #164

ZeroIntensity opened this issue May 5, 2024 · 9 comments
Assignees
@tallhypnosis
Labels
good first issue An issue that isn't necessarily easy to implement, but not required to be an expert in view.py improvement Improvement to an existing feature repo This has to do with the repository (CI, tests, etc)
Milestone
Beta Release

Comments

@ZeroIntensity
Copy link
Owner

Description:

Ward has been great, but using it over Pytest makes #109 more or less impossible. Pytest and Ward are pretty similar, but most developers are familiar with Pytest anyway, so this change will probably be for the best.
@ZeroIntensity ZeroIntensity added improvement Improvement to an existing feature good first issue An issue that isn't necessarily easy to implement, but not required to be an expert in view.py repo This has to do with the repository (CI, tests, etc) labels May 5, 2024
@tallhypnosis
Copy link
Contributor

I could work on this, if you want me to ?

@ZeroIntensity
Copy link
Owner Author

That would be great! Most of this issue will just be adding pytest.mark.asyncio and renaming the functions.

If you need to me to set up the changes to the actions workflow, I can do that for you. Nobody likes messing with workflow files.

@tallhypnosis
Copy link
Contributor

sure

@ZeroIntensity ZeroIntensity added this to the Beta milestone May 7, 2024
@ZeroIntensity
Copy link
Owner Author

Any progress here?

@tallhypnosis
Copy link
Contributor

tallhypnosis commented May 13, 2024 via email

@ZeroIntensity
Copy link
Owner Author

Great! Go ahead and make a PR, I'll update the workflows if you haven't already

@tallhypnosis
Copy link
Contributor

before i make the PR is there anything to mind or any suggestion ?

@tallhypnosis
Copy link
Contributor

Do you want me to change something in the readme or any doc file ?

@ZeroIntensity
Copy link
Owner Author

Nope, I got it.

@ZeroIntensity ZeroIntensity mentioned this issue May 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tallhypnosis tallhypnosis

Labels
good first issue An issue that isn't necessarily easy to implement, but not required to be an expert in view.py improvement Improvement to an existing feature repo This has to do with the repository (CI, tests, etc)
Projects
None yet
Milestone
Beta Release
Development

No branches or pull requests
2 participants
@ZeroIntensity @tallhypnosis