Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding tests for memory leaks in the C API #109

Closed
ZeroIntensity opened this issue Dec 30, 2023 · 0 comments · Fixed by #171
Closed

Adding tests for memory leaks in the C API #109

ZeroIntensity opened this issue Dec 30, 2023 · 0 comments · Fixed by #171
Assignees
@ZeroIntensity
Labels
c api This has to do with the C API (_view) improvement Improvement to an existing feature repo This has to do with the repository (CI, tests, etc)
Milestone
Beta Release

Comments

@ZeroIntensity
Copy link
Owner

Improvement Description

Memray should be used to ensure there are no memory leaks throughout the C API

Improvement Request Example API

N/A

Anything else?

pytest-memray looks like the best option, but view.py uses ward instead. Either it needs to be reverse-engineered for ward, or a separate testing suite needs to be set up for pytest.
@ZeroIntensity ZeroIntensity added improvement Improvement to an existing feature c api This has to do with the C API (_view) repo This has to do with the repository (CI, tests, etc) labels Dec 30, 2023
@ZeroIntensity ZeroIntensity mentioned this issue Dec 30, 2023
Open
@ZeroIntensity ZeroIntensity mentioned this issue May 5, 2024
Closed
@ZeroIntensity ZeroIntensity added this to the Beta milestone May 7, 2024
ZeroIntensity added a commit that referenced this issue May 15, 2024
@ZeroIntensity
implement #109
cf22541
@ZeroIntensity ZeroIntensity self-assigned this May 15, 2024
@ZeroIntensity ZeroIntensity mentioned this issue May 15, 2024
Merged
@ZeroIntensity ZeroIntensity linked a pull request May 18, 2024 that will close this issue
Build Steps #171
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ZeroIntensity ZeroIntensity

Labels
c api This has to do with the C API (_view) improvement Improvement to an existing feature repo This has to do with the repository (CI, tests, etc)
Projects
None yet
Milestone
Beta Release
Development

Successfully merging a pull request may close this issue.

Build Steps ZeroIntensity/view.py
1 participant
@ZeroIntensity