Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metrics): allow users to provision prometheus and grafana with docker #8216

Closed
wants to merge 2 commits into from

Conversation

gustavovalverde
Copy link
Member

@gustavovalverde gustavovalverde commented Jan 30, 2024

Motivation

This extends #8215 to also leverage metrics

This is a WIP

It can be tested with:

docker-compose -f docker/docker-compose.yml -f docker/docker-compose.lwd.yml -f docker/docker-compose.metrics.yml up

PR Author Checklist

Check before marking the PR as ready for review:

  • Will the PR name make sense to users?
  • Does the PR have a priority label?
  • Have you added or updated tests?
  • Is the documentation up to date?
For significant changes:
  • Is there a summary in the CHANGELOG?
  • Can these changes be split into multiple PRs?

If a checkbox isn't relevant to the PR, mark it as done.

Specifications

Complex Code or Requirements

Solution

Testing

Review

Reviewer Checklist

Check before approving the PR:

  • Does the PR scope match the ticket?
  • Are there enough tests to make sure it works? Do the tests cover the PR motivation?
  • Are all the PR blockers dealt with?
    PR blockers can be dealt with in new tickets or PRs.

And check the PR Author checklist is complete.

Follow Up Work

@gustavovalverde gustavovalverde added A-devops Area: Pipelines, CI/CD and Dockerfiles C-enhancement Category: This is an improvement I-usability Zebra is hard to understand or use C-feature Category: New features P-Low ❄️ labels Jan 30, 2024
@gustavovalverde gustavovalverde self-assigned this Jan 30, 2024
@mpguerra mpguerra linked an issue Jan 31, 2024 that may be closed by this pull request
Base automatically changed from feat-compose-users to main February 1, 2024 21:54
@gustavovalverde
Copy link
Member Author

This is not urgen. I'll reopen it when we got time for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-enhancement Category: This is an improvement C-feature Category: New features I-usability Zebra is hard to understand or use P-Low ❄️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

doc: Explain how to use a persistent state disk with Docker
1 participant