-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(docker): allow users to use Zebra + LWD with persistent states #8215
Conversation
This can always be overriden by forcing this pushes if it was intended
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused at how you've created two docker-compose files and how you've distributed the yaml across them. In my blog post I used just one file. I've never seen it broken out like this, so I'm probably just ignorant and my comments may be wrong. But hopefully at least one of us will come out having learned something. :)
@AArnott that's a really good question, this is a docker compose functionality https://docs.docker.com/compose/multiple-compose-files/merge/ As our users might have different needs, we've created 2 docker-compose yaml:
A user might decide to just run the Zebra node with |
That sounds good. Then why are zebra-specific things only put into the lwd file? A zebra-only container should still know its own ports and healthcheck, shouldn't it? |
@AArnott Yes, I did this as the healtcheck depends on port |
Co-authored-by: Marek <[email protected]>
Motivation
We want to make it easy for users to use Zebra and Lightwalletd without the risk of losing their cached states, and avoiding complexity when running both tools together.
Fixes #8023
PR Author Checklist
Check before marking the PR as ready for review:
For significant changes:
If a checkbox isn't relevant to the PR, mark it as done.
Complex Code or Requirements
--no-tls-very-insecure
as we can't create certificates for the usercurl
is required in our production image to allow the health-check to workSolution
docker-compose.yml
to run an isolated Zebra nodedocker-compose.lwd.yml
to run a lightwalletd server alongside Zebrazcash.conf
file for lightwalletdtest.env
to.env
Testing
This can be tested running:
For a Zcash Node, and change its behavior in
.env
To run LWD + Zcash
Review
Note: This is not ready until respective user documentation is updated
Reviewer Checklist
Check before approving the PR:
PR blockers can be dealt with in new tickets or PRs.
And check the PR Author checklist is complete.