Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable more Transaction v5 tests (automatic rebase after #2060) #2061

Closed
wants to merge 6 commits into from

Conversation

teor2345
Copy link
Contributor

Motivation

Currently, most of Zebra's proptests are testing Transaction v4, but we also want to test Transaction v5 (and NU5).

Solution

  • make NU5 the default network upgrade for proptests
  • use arbitrary LedgerStates in more tests
  • stop skipping Canopy (and later) blocks in some tests

The code in this pull request has:

  • Documentation Comments
  • Property Tests

Review

@oxarbitrage can review. These tests don't pass without his fixes to #2023.

These fixes also depend on #2060.

Follow Up Work

#2059 Use arbitrary LedgerStates in more tests to increase test coverage

@teor2345 teor2345 added C-bug Category: This is a bug A-rust Area: Updates to Rust code C-cleanup Category: This is a cleanup NU-5 Network Upgrade: NU5 specific tasks P-Medium labels Apr 23, 2021
@teor2345 teor2345 self-assigned this Apr 23, 2021
@teor2345 teor2345 added this to the 2021 Sprint 8 milestone Apr 23, 2021
@teor2345
Copy link
Contributor Author

I've marked this PR as draft because it is currently based on #2060 for easy review.

It will automatically rebase on main once #2060 merges. Then anyone can turn off draft and merge it.

@teor2345
Copy link
Contributor Author

teor2345 commented Apr 23, 2021

I also wanted to base this PR on #2057, but GitHub doesn't allow multiple bases or bases across repositories.

So I just merged #2057 into this PR so that the tests would pass.

The changes from #2057 will disappear from the diff once #2060 merges and this PR is automatically rebased on main.

Base automatically changed from test-movement to main April 23, 2021 13:34
@oxarbitrage
Copy link
Contributor

Closing in favour of #2063

@teor2345 teor2345 deleted the enable-nu5-tests branch March 21, 2022 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rust Area: Updates to Rust code C-bug Category: This is a bug C-cleanup Category: This is a cleanup NU-5 Network Upgrade: NU5 specific tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants