Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move some tests into their own files #2060

Merged
merged 2 commits into from
Apr 23, 2021
Merged

Move some tests into their own files #2060

merged 2 commits into from
Apr 23, 2021

Conversation

teor2345
Copy link
Contributor

Motivation

Zebra compiles faster when tests are in their own files.

It's also easier to read the code and tests when they're separate.

Solution

  • Move LedgerState into the block arbitrary module
  • Move some zebra-state tests into their own files

Review

Use git --color-moved to see the code movement in these changes.

@oxarbitrage can review.

I want to re-enable some tests after #2057, and those tests also depend on this PR.

These changes aren't urgent, but the re-enabled tests should be merged before we do any more Tx v5 work.

@teor2345 teor2345 added A-rust Area: Updates to Rust code C-cleanup Category: This is a cleanup NU-5 Network Upgrade: NU5 specific tasks P-Medium labels Apr 23, 2021
@teor2345 teor2345 requested a review from oxarbitrage April 23, 2021 06:12
@teor2345 teor2345 self-assigned this Apr 23, 2021
@teor2345 teor2345 added this to the 2021 Sprint 8 milestone Apr 23, 2021
@dconnolly dconnolly merged commit 04cfc22 into main Apr 23, 2021
@dconnolly dconnolly deleted the test-movement branch April 23, 2021 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rust Area: Updates to Rust code C-cleanup Category: This is a cleanup NU-5 Network Upgrade: NU5 specific tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants