Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing #399

Merged
merged 8 commits into from
Aug 29, 2023
Merged

Testing #399

merged 8 commits into from
Aug 29, 2023

Conversation

ericgaspar
Copy link
Member

Problem

  • Description of why you made this PR

Solution

  • And how do you fix that problem

PR Status

  • Code finished and ready to be reviewed/tested
  • The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

@ericgaspar
Copy link
Member Author

!testme

@yunohost-bot
Copy link

🎠
Test Badge

@Josue-T
Copy link

Josue-T commented Aug 26, 2023

Well why did you disable multi instance mode ?

@ericgaspar
Copy link
Member Author

ericgaspar commented Aug 26, 2023

I suspect multi-install teste set to 0 because the multi-install doesn't work (CI failes)?

multi_instance=0

@ericgaspar
Copy link
Member Author

!testme

@yunohost-bot
Copy link

🚀
Test Badge

@Gredin67
Copy link

can we merge this in testing #356 and further test before merging in master ?

@Gredin67
Copy link

and probably too long, but would be nice to move to packaging v2 sometime soon #401

@Josue-T
Copy link

Josue-T commented Aug 27, 2023

I suspect multi-install teste set to 0 because the multi-install doesn't work (CI failes)?

multi_instance=0

Well I see. I think we should temporary disable the multi instance test but keep enabled in the manifest.json (if possible). And when we migrate to packaging v2 find a way to enable again multi-instance tests.

Anyway we can't remove muti-instance flag in manifest.json it wight break multi-instance installation.

@ericgaspar
Copy link
Member Author

!testme

@yunohost-bot
Copy link

😜
Test Badge

@Josue-T Josue-T merged commit 8b9529f into master Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants