improve config panel

[Gredin67]

• Expose more parameters
• Use bind __FOOBAR__
• Link to first element_ynh instance element

TODO :

• Improve scripts/conf, see Add config panel with few config options and user management mautrix_whatsapp_ynh#74
• Handle list allowed_local_3pids and auto_join_rooms
• Test

[Gredin67]

!testme

[yunohost-bot]

Alrighty!

[Gredin67]

!testme

[Gredin67]

!testme

[yunohost-bot]

🎠

[Gredin67]

@Josue-T it's starting to work, but I don't know what to do with
e2e_enabled_by_default, which is not a boolean in homeserver.yaml, but

        [client.experience.e2e_enabled_by_default]
        ask = "End-to-End Encryption by default for locally-created Rooms"
        type = "select"
        choices = ["all", "invite", "off"]
        bind = "encryption_enabled_by_default_for_room_type:/etc/matrix-__APP__/homeserver.yaml"

You use e2e_enabled_by_default in many places that I don't necessarily understand. Can you sort this out?

[Gredin67]

correct parameter handling should be double-checked for (non-exhaustive)

    allow_registration
    turn_allow_guests
    sso_enabled
    password_enabled

[Gredin67]

@thardev can you check /scripts/config to see if it fits latest config_panel standards?
And also check/add sed stuff for allowed_local_3pids and auto_join_rooms

[yunohost-bot]

May the CI gods be with you!

[Thatoo]

Tonight on brand new Yunohost and Synapse install :
Install OK
In the config-panel, when I wanted to change "End-to-End Encryption by default for locally-created Rooms" from "off" to "invite", and I wanted to save, I got the following error : "Le formulaire contient des erreurs" , and it didn't change the value in the homserver.yaml

Then, I wanted to change "Largest allowed media upload size in bytes." from 10M to 100M and it failed, here is the yunopaste : https://paste.yunohost.org/raw/avaxisujeg
but it has indeed changed the value in the homserver.yaml

Finally, I tried to change "Server statistics" from off to on and this worked and it has indeed changed the value in the homserver.yaml

[Thatoo]

Enable Registration for new users : worked to change it from false to true but not from true to false... "Le formulaire contient des erreurs"

Disable asking Phone Number in Registration flow worked to change it from true to false but not the opposite : "Le formulaire contient des erreurs"

Auto-Create room for Auto Join if not existing? didn't work at all : "Le formulaire contient des erreurs"

Enable email notifications for new users? didn't work at all : "Le formulaire contient des erreurs"

Access Public Rooms Directory over Federation? didn't work at all : "Le formulaire contient des erreurs"

Disable content sharing inside push notification. didn't work at all : "Le formulaire contient des erreurs"

Allow non-server-admin Users to create Spaces? didn't work at all : "Le formulaire contient des erreurs"

Enable sending emails for messages the user missed? didn't work at all : "Le formulaire contient des erreurs"

[Josue-T]

lgtm! @Josue-T can you please merge in testing ? @YunoHost-Apps/matrix-bridges anyone could test upgrade and functionality of the new config panel ?

Maybe we need to investigate the last issues message before to merge it.

[MayeulC]

There is already a mechanism that backs up the old config and warns the user with the diff. If you want to improve this, it should be done in yunohost core, not in this package.

Of course, not necessary for this PR, but as a datapoint, here is what I modify in my config:

• enable metrics, and add a localhost listener (that I use with yunohost's prometheus package, to then plot everything in grafana)
• adjust cache factors (both global_factor and sync_response_cache_duration as I have plenty of RAM)
• whitelist 127.0.0.1 in ip_range_whitelist, as I run a push server (ntfy for UnifiedPush) at this address.

The above could easily be added as options in the config panel (possibly in an "advanced" section).

[Gredin67]

Feel free to add it :) Le 28 août 2023 10:13:26 GMT+02:00, Mayeul Cantan ***@***.***> a écrit :

…

> There is already a mechanism that backs up the old config and warns the user with the diff. If you want to improve this, it should be done in yunohost core, not in this package. Of course, not necessary for this PR, but as a datapoint, here is what I modify in my config: - enable metrics, and add a localhost listener (that I use with yunohost's prometheus package, to then plot everything in grafana) - adjust cache factors (both `global_factor` and `sync_response_cache_duration` as I have plenty of RAM) - whitelist `127.0.0.1` in `ip_range_whitelist`, as I run a push server (ntfy for UnifiedPush) at this address. The above could easily be added as options in the config panel (possibly in an "advanced" section). -- Reply to this email directly or view it on GitHub: #356 (comment) You are receiving this because you were mentioned. Message ID: ***@***.***>

[rosbeef]

I'm focusing on my last addition account_threepid_delegates_msisdn and enable_registration for now.

I have some clues :

1. I don't understand why it is at the top of the setting.yml file (maybe sed config script is not working on the first line,(sort of speculation from my part but i read something somewere about that ))
2. When i run yunohost app config set synapse__2 main.welcome.account_threepid_delegates_msisdn -v 'https://127.0.0.1:2345' do nothing as it don't find any modifications, which is false.
3. Run yunohost app config get synapse__2 returns me "account_threepid_delegates_msisdn" values as empty, not "none" as others empty values.

Please someone can test if i'm right.
When i put account_threepid_delegates_msisdn at the middle of the setting.yml , setting enable_registration from true to false works.

[rosbeef]

Fix "false" value to "none" in select field
It seems the bug was related to the value of the requires_registration_3pid . The requires_registration_3pid default value setted to false in the install script and was interpreted as a boolean.
So getting the value to show in the config panel generate a bug as 0 is not a valid value to choose in the select type field.
To mitigate i change the default value to none in Install, upgrade scripts and config-panel.toml

please proceed with tests
i will sleep ;)

[Josue-T]

Hello,

@rosbeef @Gredin67 did you test the last version ? Does everything works ?

[Gredin67]

Please merge in testing to increase visibility and get more testers. config panel cannot break anything but the config file. @Thatoo should be able to test again soon. Le 12 septembre 2023 18:32:13 GMT+02:00, Josue-T ***@***.***> a écrit :

…

Hello, @rosbeef @Gredin67 did you test the last version ? Does everything works ? -- Reply to this email directly or view it on GitHub: #356 (comment) You are receiving this because you were mentioned. Message ID: ***@***.***>

[Thatoo]

• Password login option is not working : it does not change the option in the homserver.yaml file (line 2171)
• Enable registration option works but it automatically set

registrations_require_3pid:
 - email
 # - msisdn

even though Registration requires all following 3PID personal identifier is set to none.

• Auto Join new Users in following Rooms option works
• Auto-Create room for Auto Join if not existing? option works
• Enable email notifications for new users? option works
• End-to-End Encryption by default for locally-created Rooms option works
• Access Public Rooms Directory over Federation? option works
• Disable content sharing inside push notification option works
• Element instance your HomeServer should redirect to option works
• Allow non-server-admin Users to create Spaces? option works
• Enable sending emails for messages the user missed? option works but I don't understand why it is far down from the Enable email notifications for new users? option , I would imagine notififcation options being close to each other in the list
• URL for client links within the email notifications. option works
• Largest allowed media upload size in bytes. option fails, I can't change it from 10M to 100M, I get an error : https://paste.yunohost.org/raw/xahexixizi
• Backup before upgrade? option was not tested, I don't know where to check that in homeserver.yaml file
• Server statistics option works
• Web client location to direct users to during an invite. option works
• Allow Users to Register as Guests? option works
• Enable Auto Join Room for Guests? option works
• Allow discovering friends with phone number or email? option works
• Identity server suggested to clients? option works
• Access Public Rooms Directory without authentification? option works
• Shared Secret for Registration. option works
• Should guests be allowed to use the TURN server? option works

[rosbeef]

• Largest allowed media upload size in bytes. option fails, I can't change it from 10M to 100M, I get an error : https://paste.yunohost.org/raw/xahexixizi

Sorry i have no time till monday. But this error Come from the $domain variable which does not exist.

[rosbeef]

• Enable registration option works but it automatically set

registrations_require_3pid:
 - email
 # - msisdn

For this maybe those values are the default in config file and should be set to all commented.

I vote for removing the enable registration switch in the install panel too. This should simplify install for non techies and simplify scripts

[Thatoo]

I just realize that it is quiet urgent as testing has been merged in master now...

[rosbeef]

Dmne is it possible to suspend upgrade?

[rosbeef]

Sorry, just to be informed, how is the "workflow" to merge testing into master generally in yunohost apps??
I will try to do something Saturday, but till this I'm only with my mobile and it's not really usable.

[Gredin67]

Why would you do this? In the worst case the config panel is not working (as before). And people only have to change settings manually in the config file. Unfortunately i'm out for 2 weeks. So I hope one of you can find time to fix those 2 small settings migration issues. Le 21 septembre 2023 21:53:14 GMT+02:00, rosbeef andino ***@***.***> a écrit :

…

Dmne is it possible to suspend upgrade? -- Reply to this email directly or view it on GitHub: #356 (comment) You are receiving this because you were mentioned. Message ID: ***@***.***>