Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use AppData in Linux builds #532

Merged
merged 1 commit into from
Jan 31, 2020
Merged

Use AppData in Linux builds #532

merged 1 commit into from
Jan 31, 2020

Conversation

ai
Copy link

@ai ai commented Jan 30, 2020

In #524 we added appdata.xml file to the repository. In this PR we are using it during install scripts for Linux.

  • I added AppData to Debian script according to Debian guideline
  • I didn’t check AppImageKit, but according to it’s sources AppImageKit should load AppData from appDir/

@dagheyman We will need a release after merging this PR to start working for Flatpak.

@dagheyman
Copy link

Actually, we currently don't publish any debian packages ourselves (there is an effort to do it elsewhere though, see #328 (comment)). So I was planning on removing the whole debian/ folder from the repository. Are those files used directly by Flatpak ?

The appimage part of the PR looks fine.

@ai
Copy link
Author

ai commented Jan 31, 2020

Do you build deb or rpm? I thought that AppImageKit is used for it.

@dagheyman
Copy link

No, its only used for the .AppImage found on https://developers.yubico.com/yubioath-desktop/Releases/

@ai
Copy link
Author

ai commented Jan 31, 2020

It is strange that you build not so popular AppImage and not more popular snap or Flatpak 😅

OK, with this new information I need a day for investigating.

@ai
Copy link
Author

ai commented Jan 31, 2020

Seems like we do not need anything special for Flatpak. I will update flathub/flathub PR on weekend.

I think AppImage can still win from AppData: https://docs.appimage.org/packaging-guide/appstream.html

If we have debian/ let’s update them as well. At least for theoretical consistency, rather than rational reasons.

But yeap, we do not need a release.

@dagheyman
Copy link

Thanks for clarifying. Merging this, with the caveat that the whole debian directory will probably be removed soon.

@dagheyman dagheyman merged commit aee249c into Yubico:master Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants