-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Appdata #524
Appdata #524
Conversation
</screenshot> | ||
</screenshots> | ||
|
||
<releases> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would drop the releases section for now and keep this minimal, since we already maintain the NEWS file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The releases are valuable info, it's used in Flathub/GNOME Software/KDE Discover/.. to show to the user which version is available/installed on their system.
It's also a requirement for publishing an application on Flathub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The NEWS file, is mostly read by: contributors, collaborators, developers or someone involved with the code source. The releases tags here targets a general audience (less technical) I would say
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't know that it was a requirement for Flathub. I'm happy to include these again as they were (sorry @ai ... ), and we'll look into later how to sync the content for them for upcoming releases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It shouldn't be hard with https://blog.tenstral.net/2020/01/a-big-appstream-status-update.html. There's now a news-to-metainfo
command shipped with appstream-util if you want to automate the task.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reverted releases
removal and add fresh 5.0.2 release there 5883176
Looks good! See comments for feedback. |
Fixed 😺 |
Very fast! Added a couple more :) |
|
||
<name>Yubico Authenticator</name> | ||
<summary>Graphical interface for displaying OATH codes with a YubiKey</summary> | ||
<url type="homepage">https://developers.yubico.com/yubioath-desktop/</url> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could use a bugtracker url
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This repository, as well as the URL to open a support ticket ( https://support.yubico.com/support/tickets/new ) is fine to include.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replaced ccad977
Thanks for all the work on this, merging! |
Another backport from Flatpak PR — AppStream metadata.
I also renamed
.desktop
file to reverse DNS naming (because of the same reasons behind renaming the icon, hope I didn’t forget to change path somewhere as I did it in the previous PR 😓).Why this metadata should be in upstream?
Is it correct?
flatpak run org.freedesktop.appstream-glib validate
validator.Notes about the content of metadata:
CC0-1.0
formetadata_license
according to very free license recommendations to be able to use description/screenshot in different stores and cases.Yubico
name indeveloper_name
. Should we rename it toYubico developers
or to your name?update_contact
as a promise to help you with a file in the future. But we can replace it with another contact.5.0.1
and5.0.0
notes toreleases
. Technically, we can removereleases
. But it will be so nice to see changes directly in Linux’s apps store.