Fix simpleuart baud rate calculation #162
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes the baud rate calculation so that the behavior of
simpleuart is in line with the description in picosoc/README.md:
> The UART Clock Divider Register must be set to the system clock
> frequency divided by the baud rate.
Previously, the effective behavior of simpleuart was
divisor = (clock frequency / baud rate) - 2
The fix is done basically by comparing `*_divcnt + 1 >= cfg_divider`
instead of the old `*_divcnt > cfg_divider`. A special case is needed in
the receive logic for the case where the divider is equal to 1, where at
the next cycle we want to read the first bit (jumping straight to a
`recv_state` of 2).
This patch also makes some minor stylistic changes that fix Verilator
lint errors.
anishathalye
force-pushed
the
simpleuart-baud
branch
from
52a44fe
to
9aae963
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes the baud rate calculation so that the behavior of simpleuart is in line with the description in picosoc/README.md:
Previously, the effective behavior of simpleuart was
The fix is done basically by comparing
*_divcnt + 1 >= cfg_dividerinstead of the old*_divcnt > cfg_divider. A special case is needed in the receive logic for the case where the divider is equal to 1, where at the next cycle we want to read the first bit (jumping straight to arecv_stateof 2).This patch also makes some minor stylistic changes that fix Verilator lint errors (let me know if you prefer that I remove these).
Fixes #140.