-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: output field information in green and messages in orange #1498
feat: output field information in green and messages in orange #1498
Conversation
@fukusuket Thanks so much! Looking great! One small part, I noticed |
@YamatoSecurity |
The color can be changed by erasing the progress bar itself at the end of the progress bar, but I think it is easier to understand if the progress bar is output at 100%. |
Sorry, I noticed that commands other than timeline (metrics/pivot ... etc) still need to be colored, so I'm fixing it! |
@YamatoSecurity |
@fukusuket Thanks! I figured out how to make the "Scanning finished...." message orange but it is still orange when |
@YamatoSecurity |
@fukusuket Thanks! Could you add a space here:
After:
|
Sorry, it is unrelated to this PR but here:
Can you remove the |
Sorry, the |
Thank you for checking! I fixed above comments! |
thanks! Sorry, one more small thing:
can you add a space here ->
|
sorry! here as well
->
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fukusuket Perfect! Thanks so much!
What Changed
Evidence
Integration-Test
https://github.com/Yamato-Security/hayabusa/actions/runs/11853318764
I would appreciate it if you could check it out when you have time🙏