Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output field information in green and messages in orange #1491

Closed
YamatoSecurity opened this issue Nov 12, 2024 · 6 comments · Fixed by #1498
Closed

Output field information in green and messages in orange #1491

YamatoSecurity opened this issue Nov 12, 2024 · 6 comments · Fixed by #1498
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@YamatoSecurity
Copy link
Collaborator

For the following output when running:

Start time: 2024/11/13 08:03

Total event log files: 598
Total file size: 139.2 MB

Loading detection rules. Please wait.

Excluded rules: 26
Noisy rules: 12 (Disabled)

Deprecated rules: 216 (5.01%) (Disabled)
Experimental rules: 373 (8.65%)
Stable rules: 241 (5.59%)
Test rules: 3,700 (85.77%)
Unsupported rules: 42 (0.97%) (Disabled)

Correlation rules: 3 (0.07%)
Correlation referenced rules: 3 (0.07%)

Hayabusa rules: 175
Sigma rules: 4,139
Total detection rules: 4,314

Creating the channel filter. Please wait.

Evtx files loaded after channel filter: 585
Detection rules enabled after channel filter: 4,237

Output profile: standard

I would like to output the hogehoge: parts (Ex: Start time:, Total event log files:, etc...) in the same green as the HAYABUSA logo. (With the ability to disable colors with the --no-color option.)
Also Scan wizard: in green.
At the end:

Elapsed time: 00:00:07.1247

Please report any issues with Hayabusa rules to: https://github.com/Yamato-Security/hayabusa-rules/issues
Please report any false positives with Sigma rules to: https://github.com/SigmaHQ/sigma/issues
Please submit new Sigma rules with pull requests to: https://github.com/SigmaHQ/sigma/pulls

Elapsed time:, Please report any issues with Hayabusa rules to:, etc... also in green.

I want to output Loading detection rules. Please wait., Creating the channel filter. Please wait., Scanning finished. in the same orange color as ? and (y/n) in the scan wizard settings.

I think this will make things easier to read and look better.

@fukusuket could I ask you to do this one?

@YamatoSecurity YamatoSecurity added the enhancement New feature or request label Nov 12, 2024
@YamatoSecurity YamatoSecurity added this to the 2.19.0 milestone Nov 12, 2024
@fukusuket
Copy link
Collaborator

Sounds Good! Yes, I would love to implement it!💪

@fukusuket fukusuket self-assigned this Nov 13, 2024
@fukusuket
Copy link
Collaborator

Color::Rgb(0, 255, 0) // green
Style::new().color256(46), // green

Color::Rgb(0,255,255) // cyan
Style::new().color256(51), // cyan

Color::Rgb(255,175,0) // orange
Style::new().color256(214).apply_to("❯".to_string()), // orange

@fukusuket
Copy link
Collaborator

@YamatoSecurity
Is it correct that the following message is also output in orange? 👀

@YamatoSecurity
Copy link
Collaborator Author

Yes! I'd also like to output these messages in orange.

@YamatoSecurity Is it correct that the following message is also output in orange? 👀

@fukusuket
Copy link
Collaborator

@YamatoSecurity
I have a question! Which specification is the expected behavior?

  • Start time: <- Orange + 2024/11/13 08:03<- white
  • Start time: 2024/11/13 08:03 <- whole Orange

@YamatoSecurity
Copy link
Collaborator Author

@YamatoSecurity I have a question! Which specification is the expected behavior?

  • Start time: <- Orange + 2024/11/13 08:03<- white
  • Start time: 2024/11/13 08:03 <- whole Orange

I would like to do Start time: <- Green + 2024/11/13 08:03<- white

but whole orange for things like the opening messages, warning messages, etc.. (The places that don't have field: something format.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants