Audit implementations #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin
* audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins
* audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * audit: timelock in admin functions of vault #66
…s not end and epoch (#68) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * audit: timelock in admin functions of vault #66 * audit: getLatestPrice in event of triggerEndEpoch * epochHasEnded * goerli deployment * natspec comments * add quick fix to test before PR refactoring * 46 audit oracle outdated issues (#63) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * removed admin * add assert to testOwnerAuthorize * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * erased dup test * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * 46 audit oracle outdated issues (#63) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * dup of trigger null epoch Co-authored-by: 0xnexusflip <[email protected]>
* audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * audit: timelock in admin functions of vault #66 * audit: getLatestPrice in event of triggerEndEpoch * audit: Change the isDisaster modifier to revert when price of a pegged asset is equal to the strike price of a Vault * epochHasEnded * goerli deployment * natspec comments * add quick fix to test before PR refactoring * 46 audit oracle outdated issues (#63) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * removed admin * add assert to testOwnerAuthorize * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * unused local var * 66 audit timelock in admin functions of vault (#67) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * audit: timelock in admin functions of vault #66 * 41 audit getlatestprice when calling endepoch with sequencer down does not end and epoch (#68) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * audit: timelock in admin functions of vault #66 * audit: getLatestPrice in event of triggerEndEpoch * epochHasEnded * goerli deployment * natspec comments * add quick fix to test before PR refactoring * 46 audit oracle outdated issues (#63) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * removed admin * add assert to testOwnerAuthorize * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * erased dup test * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * 46 audit oracle outdated issues (#63) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * dup of trigger null epoch Co-authored-by: 0xnexusflip <[email protected]> * missing address Co-authored-by: 0xnexusflip <[email protected]>
…82) * 71 audit missing assert verification on transfer of tokens (#81) * 46 audit oracle outdated issues (#63) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * removed admin * add assert to testOwnerAuthorize * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * unused local var * 66 audit timelock in admin functions of vault (#67) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * audit: timelock in admin functions of vault #66 * 41 audit getlatestprice when calling endepoch with sequencer down does not end and epoch (#68) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * audit: timelock in admin functions of vault #66 * audit: getLatestPrice in event of triggerEndEpoch * epochHasEnded * goerli deployment * natspec comments * add quick fix to test before PR refactoring * 46 audit oracle outdated issues (#63) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * removed admin * add assert to testOwnerAuthorize * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * erased dup test * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * 46 audit oracle outdated issues (#63) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * dup of trigger null epoch Co-authored-by: 0xnexusflip <[email protected]> * missing address * 69 audit depeg event can happen at incorrect price (#70) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * audit: timelock in admin functions of vault #66 * audit: getLatestPrice in event of triggerEndEpoch * audit: Change the isDisaster modifier to revert when price of a pegged asset is equal to the strike price of a Vault * epochHasEnded * goerli deployment * natspec comments * add quick fix to test before PR refactoring * 46 audit oracle outdated issues (#63) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * removed admin * add assert to testOwnerAuthorize * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * unused local var * 66 audit timelock in admin functions of vault (#67) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * audit: timelock in admin functions of vault #66 * 41 audit getlatestprice when calling endepoch with sequencer down does not end and epoch (#68) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * audit: timelock in admin functions of vault #66 * audit: getLatestPrice in event of triggerEndEpoch * epochHasEnded * goerli deployment * natspec comments * add quick fix to test before PR refactoring * 46 audit oracle outdated issues (#63) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * removed admin * add assert to testOwnerAuthorize * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * erased dup test * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * 46 audit oracle outdated issues (#63) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * dup of trigger null epoch Co-authored-by: 0xnexusflip <[email protected]> * missing address Co-authored-by: 0xnexusflip <[email protected]> * audit: #383 * audit: #379 * audit #118 * remove hashed index * change treasure address 0 * deposit event with useless param * audit deposit evnt * audit: fee cannot be 0 * add timelock, strk price, null epoch tests * add testFeeCannotBe0 * add testControllerNotSet * timelock assert test * test fail for timelockers * tests of epochnull and withdraw without fee * test epoch already finished * EpochFinishedAlready and epochNull tests * testing suite update on reverts * comment out test testVaultAddressZero * assert on all asset.transfers Co-authored-by: 0xnexusflip <[email protected]> * Revert "71 audit missing assert verification on transfer of tokens (#81)" This reverts commit 79d913a. Co-authored-by: 0xnexusflip <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.