39 audit controllersol needs to implement tvl cant be zero #64

MiguelBits · 2022-09-23T17:08:10Z

No description provided.

…l-cant-be-zero

…s-to-implement-tvl-cant-be-zero

* audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins

…s not end and epoch (#68) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * audit: timelock in admin functions of vault #66 * audit: getLatestPrice in event of triggerEndEpoch * epochHasEnded * goerli deployment * natspec comments * add quick fix to test before PR refactoring * 46 audit oracle outdated issues (#63) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * removed admin * add assert to testOwnerAuthorize * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * erased dup test * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * 46 audit oracle outdated issues (#63) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * dup of trigger null epoch Co-authored-by: 0xnexusflip <[email protected]>

* audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins

…s not end and epoch (#68) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * audit: timelock in admin functions of vault #66 * audit: getLatestPrice in event of triggerEndEpoch * epochHasEnded * goerli deployment * natspec comments * add quick fix to test before PR refactoring * 46 audit oracle outdated issues (#63) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * removed admin * add assert to testOwnerAuthorize * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * erased dup test * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * 46 audit oracle outdated issues (#63) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * dup of trigger null epoch Co-authored-by: 0xnexusflip <[email protected]>

* audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * audit: timelock in admin functions of vault #66 * audit: getLatestPrice in event of triggerEndEpoch * audit: Change the isDisaster modifier to revert when price of a pegged asset is equal to the strike price of a Vault * epochHasEnded * goerli deployment * natspec comments * add quick fix to test before PR refactoring * 46 audit oracle outdated issues (#63) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * removed admin * add assert to testOwnerAuthorize * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * unused local var * 66 audit timelock in admin functions of vault (#67) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * audit: timelock in admin functions of vault #66 * 41 audit getlatestprice when calling endepoch with sequencer down does not end and epoch (#68) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * audit: timelock in admin functions of vault #66 * audit: getLatestPrice in event of triggerEndEpoch * epochHasEnded * goerli deployment * natspec comments * add quick fix to test before PR refactoring * 46 audit oracle outdated issues (#63) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * removed admin * add assert to testOwnerAuthorize * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * erased dup test * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * 46 audit oracle outdated issues (#63) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * dup of trigger null epoch Co-authored-by: 0xnexusflip <[email protected]> * missing address Co-authored-by: 0xnexusflip <[email protected]>

* 46 audit oracle outdated issues (#63) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * removed admin * add assert to testOwnerAuthorize * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * unused local var * 66 audit timelock in admin functions of vault (#67) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * audit: timelock in admin functions of vault #66 * 41 audit getlatestprice when calling endepoch with sequencer down does not end and epoch (#68) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * audit: timelock in admin functions of vault #66 * audit: getLatestPrice in event of triggerEndEpoch * epochHasEnded * goerli deployment * natspec comments * add quick fix to test before PR refactoring * 46 audit oracle outdated issues (#63) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * removed admin * add assert to testOwnerAuthorize * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * erased dup test * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * 46 audit oracle outdated issues (#63) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * dup of trigger null epoch Co-authored-by: 0xnexusflip <[email protected]> * missing address * 69 audit depeg event can happen at incorrect price (#70) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * audit: timelock in admin functions of vault #66 * audit: getLatestPrice in event of triggerEndEpoch * audit: Change the isDisaster modifier to revert when price of a pegged asset is equal to the strike price of a Vault * epochHasEnded * goerli deployment * natspec comments * add quick fix to test before PR refactoring * 46 audit oracle outdated issues (#63) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * removed admin * add assert to testOwnerAuthorize * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * unused local var * 66 audit timelock in admin functions of vault (#67) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * audit: timelock in admin functions of vault #66 * 41 audit getlatestprice when calling endepoch with sequencer down does not end and epoch (#68) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * audit: timelock in admin functions of vault #66 * audit: getLatestPrice in event of triggerEndEpoch * epochHasEnded * goerli deployment * natspec comments * add quick fix to test before PR refactoring * 46 audit oracle outdated issues (#63) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * removed admin * add assert to testOwnerAuthorize * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * erased dup test * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * 46 audit oracle outdated issues (#63) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * dup of trigger null epoch Co-authored-by: 0xnexusflip <[email protected]> * missing address Co-authored-by: 0xnexusflip <[email protected]> * audit: #383 * audit: #379 * audit #118 * remove hashed index * change treasure address 0 * deposit event with useless param * audit deposit evnt * audit: fee cannot be 0 * add timelock, strk price, null epoch tests * add testFeeCannotBe0 * add testControllerNotSet * timelock assert test * test fail for timelockers * tests of epochnull and withdraw without fee * test epoch already finished * EpochFinishedAlready and epochNull tests * testing suite update on reverts * comment out test testVaultAddressZero * assert on all asset.transfers Co-authored-by: 0xnexusflip <[email protected]>

…82) * 71 audit missing assert verification on transfer of tokens (#81) * 46 audit oracle outdated issues (#63) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * removed admin * add assert to testOwnerAuthorize * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * unused local var * 66 audit timelock in admin functions of vault (#67) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * audit: timelock in admin functions of vault #66 * 41 audit getlatestprice when calling endepoch with sequencer down does not end and epoch (#68) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * audit: timelock in admin functions of vault #66 * audit: getLatestPrice in event of triggerEndEpoch * epochHasEnded * goerli deployment * natspec comments * add quick fix to test before PR refactoring * 46 audit oracle outdated issues (#63) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * removed admin * add assert to testOwnerAuthorize * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * erased dup test * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * 46 audit oracle outdated issues (#63) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * dup of trigger null epoch Co-authored-by: 0xnexusflip <[email protected]> * missing address * 69 audit depeg event can happen at incorrect price (#70) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * audit: timelock in admin functions of vault #66 * audit: getLatestPrice in event of triggerEndEpoch * audit: Change the isDisaster modifier to revert when price of a pegged asset is equal to the strike price of a Vault * epochHasEnded * goerli deployment * natspec comments * add quick fix to test before PR refactoring * 46 audit oracle outdated issues (#63) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * removed admin * add assert to testOwnerAuthorize * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * unused local var * 66 audit timelock in admin functions of vault (#67) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * audit: timelock in admin functions of vault #66 * 41 audit getlatestprice when calling endepoch with sequencer down does not end and epoch (#68) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * audit: timelock in admin functions of vault #66 * audit: getLatestPrice in event of triggerEndEpoch * epochHasEnded * goerli deployment * natspec comments * add quick fix to test before PR refactoring * 46 audit oracle outdated issues (#63) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * removed admin * add assert to testOwnerAuthorize * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * erased dup test * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * 46 audit oracle outdated issues (#63) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * dup of trigger null epoch Co-authored-by: 0xnexusflip <[email protected]> * missing address Co-authored-by: 0xnexusflip <[email protected]> * audit: #383 * audit: #379 * audit #118 * remove hashed index * change treasure address 0 * deposit event with useless param * audit deposit evnt * audit: fee cannot be 0 * add timelock, strk price, null epoch tests * add testFeeCannotBe0 * add testControllerNotSet * timelock assert test * test fail for timelockers * tests of epochnull and withdraw without fee * test epoch already finished * EpochFinishedAlready and epochNull tests * testing suite update on reverts * comment out test testVaultAddressZero * assert on all asset.transfers Co-authored-by: 0xnexusflip <[email protected]> * Revert "71 audit missing assert verification on transfer of tokens (#81)" This reverts commit 79d913a. Co-authored-by: 0xnexusflip <[email protected]>

3xHarry · 2022-10-04T14:11:20Z

src/Vault.sol

@@ -357,6 +363,10 @@ contract Vault is SemiFungibleVault, ReentrancyGuard {
        asset.transfer(_counterparty, idFinalTVL[id]);
    }

+    function setEpochNull(uint256 id) public onlyController {


@MiguelBits this is never set in triggerNullEpoch.

* 46 audit oracle outdated issues (#63) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * removed admin * add assert to testOwnerAuthorize * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * unused local var * 66 audit timelock in admin functions of vault (#67) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * audit: timelock in admin functions of vault #66 * 41 audit getlatestprice when calling endepoch with sequencer down does not end and epoch (#68) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * audit: timelock in admin functions of vault #66 * audit: getLatestPrice in event of triggerEndEpoch * epochHasEnded * goerli deployment * natspec comments * add quick fix to test before PR refactoring * 46 audit oracle outdated issues (#63) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * removed admin * add assert to testOwnerAuthorize * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * erased dup test * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * 46 audit oracle outdated issues (#63) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * dup of trigger null epoch Co-authored-by: 0xnexusflip <[email protected]> * missing address * 69 audit depeg event can happen at incorrect price (#70) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * audit: timelock in admin functions of vault #66 * audit: getLatestPrice in event of triggerEndEpoch * audit: Change the isDisaster modifier to revert when price of a pegged asset is equal to the strike price of a Vault * epochHasEnded * goerli deployment * natspec comments * add quick fix to test before PR refactoring * 46 audit oracle outdated issues (#63) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * removed admin * add assert to testOwnerAuthorize * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * unused local var * 66 audit timelock in admin functions of vault (#67) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * audit: timelock in admin functions of vault #66 * 41 audit getlatestprice when calling endepoch with sequencer down does not end and epoch (#68) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * audit: timelock in admin functions of vault #66 * audit: getLatestPrice in event of triggerEndEpoch * epochHasEnded * goerli deployment * natspec comments * add quick fix to test before PR refactoring * 46 audit oracle outdated issues (#63) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * removed admin * add assert to testOwnerAuthorize * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * erased dup test * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * 46 audit oracle outdated issues (#63) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * dup of trigger null epoch Co-authored-by: 0xnexusflip <[email protected]> * missing address Co-authored-by: 0xnexusflip <[email protected]> * audit: #383 * audit: #379 * audit #118 * remove hashed index * change treasure address 0 * deposit event with useless param * audit deposit evnt * audit: fee cannot be 0 * add timelock, strk price, null epoch tests * add testFeeCannotBe0 * add testControllerNotSet * timelock assert test * test fail for timelockers * tests of epochnull and withdraw without fee * test epoch already finished * EpochFinishedAlready and epochNull tests * testing suite update on reverts * comment out test testVaultAddressZero * Revert 81 71 audit missing assert verification on transfer of tokens (#82) * 71 audit missing assert verification on transfer of tokens (#81) * 46 audit oracle outdated issues (#63) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * removed admin * add assert to testOwnerAuthorize * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * unused local var * 66 audit timelock in admin functions of vault (#67) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * audit: timelock in admin functions of vault #66 * 41 audit getlatestprice when calling endepoch with sequencer down does not end and epoch (#68) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * audit: timelock in admin functions of vault #66 * audit: getLatestPrice in event of triggerEndEpoch * epochHasEnded * goerli deployment * natspec comments * add quick fix to test before PR refactoring * 46 audit oracle outdated issues (#63) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * removed admin * add assert to testOwnerAuthorize * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * erased dup test * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * 46 audit oracle outdated issues (#63) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * dup of trigger null epoch Co-authored-by: 0xnexusflip <[email protected]> * missing address * 69 audit depeg event can happen at incorrect price (#70) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * audit: timelock in admin functions of vault #66 * audit: getLatestPrice in event of triggerEndEpoch * audit: Change the isDisaster modifier to revert when price of a pegged asset is equal to the strike price of a Vault * epochHasEnded * goerli deployment * natspec comments * add quick fix to test before PR refactoring * 46 audit oracle outdated issues (#63) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * removed admin * add assert to testOwnerAuthorize * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * unused local var * 66 audit timelock in admin functions of vault (#67) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * audit: timelock in admin functions of vault #66 * 41 audit getlatestprice when calling endepoch with sequencer down does not end and epoch (#68) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * audit: timelock in admin functions of vault #66 * audit: getLatestPrice in event of triggerEndEpoch * epochHasEnded * goerli deployment * natspec comments * add quick fix to test before PR refactoring * 46 audit oracle outdated issues (#63) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * removed admin * add assert to testOwnerAuthorize * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * erased dup test * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * 46 audit oracle outdated issues (#63) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * dup of trigger null epoch Co-authored-by: 0xnexusflip <[email protected]> * missing address Co-authored-by: 0xnexusflip <[email protected]> * audit: #383 * audit: #379 * audit #118 * remove hashed index * change treasure address 0 * deposit event with useless param * audit deposit evnt * audit: fee cannot be 0 * add timelock, strk price, null epoch tests * add testFeeCannotBe0 * add testControllerNotSet * timelock assert test * test fail for timelockers * tests of epochnull and withdraw without fee * test epoch already finished * EpochFinishedAlready and epochNull tests * testing suite update on reverts * comment out test testVaultAddressZero * assert on all asset.transfers Co-authored-by: 0xnexusflip <[email protected]> * Revert "71 audit missing assert verification on transfer of tokens (#81)" This reverts commit 79d913a. Co-authored-by: 0xnexusflip <[email protected]> * assert on all asset.transfers (#84) * add author to contracts * audit marketExists on controller functs (#85) * remove getNextEpoch * audit: Vault receiver != address(0) * audit: oracle for more than 18 and for less than 18 decimals * audit: multiply before dividing #77 * test out lowest fee possible * audit: #79 * timelock for factory instead of vault * onlyAdmin to onlyOwner Ownable * fix overflow on previewWithdraw * fee calculation on premium * fix testWithdrawDepeg() and WithdrawEndEpoch() * revert event naming in RewardsFactory * removed hashed index * add testOracleDecimals() template * change strike on deploy script * qa for oracle decimals * timelocker contract with queue and execute * policy role * policy == owner * remove rewards duration and rewards rate * useless rewardsDuration and rewardRate * config json * json parser * deploy with json config * deploy more assets script Co-authored-by: 0xnexusflip <[email protected]>

* 46 audit oracle outdated issues (#63) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * removed admin * add assert to testOwnerAuthorize * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * unused local var * 66 audit timelock in admin functions of vault (#67) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * audit: timelock in admin functions of vault #66 * 41 audit getlatestprice when calling endepoch with sequencer down does not end and epoch (#68) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * audit: timelock in admin functions of vault #66 * audit: getLatestPrice in event of triggerEndEpoch * epochHasEnded * goerli deployment * natspec comments * add quick fix to test before PR refactoring * 46 audit oracle outdated issues (#63) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * removed admin * add assert to testOwnerAuthorize * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * erased dup test * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * 46 audit oracle outdated issues (#63) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * dup of trigger null epoch Co-authored-by: 0xnexusflip <[email protected]> * missing address * 69 audit depeg event can happen at incorrect price (#70) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * audit: timelock in admin functions of vault #66 * audit: getLatestPrice in event of triggerEndEpoch * audit: Change the isDisaster modifier to revert when price of a pegged asset is equal to the strike price of a Vault * epochHasEnded * goerli deployment * natspec comments * add quick fix to test before PR refactoring * 46 audit oracle outdated issues (#63) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * removed admin * add assert to testOwnerAuthorize * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * unused local var * 66 audit timelock in admin functions of vault (#67) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * audit: timelock in admin functions of vault #66 * 41 audit getlatestprice when calling endepoch with sequencer down does not end and epoch (#68) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * audit: timelock in admin functions of vault #66 * audit: getLatestPrice in event of triggerEndEpoch * epochHasEnded * goerli deployment * natspec comments * add quick fix to test before PR refactoring * 46 audit oracle outdated issues (#63) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * removed admin * add assert to testOwnerAuthorize * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * erased dup test * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * 46 audit oracle outdated issues (#63) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * dup of trigger null epoch Co-authored-by: 0xnexusflip <[email protected]> * missing address Co-authored-by: 0xnexusflip <[email protected]> * audit: #383 * audit: #379 * audit #118 * remove hashed index * change treasure address 0 * deposit event with useless param * audit deposit evnt * audit: fee cannot be 0 * add timelock, strk price, null epoch tests * add testFeeCannotBe0 * add testControllerNotSet * timelock assert test * test fail for timelockers * tests of epochnull and withdraw without fee * test epoch already finished * EpochFinishedAlready and epochNull tests * testing suite update on reverts * comment out test testVaultAddressZero * Revert 81 71 audit missing assert verification on transfer of tokens (#82) * 71 audit missing assert verification on transfer of tokens (#81) * 46 audit oracle outdated issues (#63) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * removed admin * add assert to testOwnerAuthorize * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * unused local var * 66 audit timelock in admin functions of vault (#67) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * audit: timelock in admin functions of vault #66 * 41 audit getlatestprice when calling endepoch with sequencer down does not end and epoch (#68) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * audit: timelock in admin functions of vault #66 * audit: getLatestPrice in event of triggerEndEpoch * epochHasEnded * goerli deployment * natspec comments * add quick fix to test before PR refactoring * 46 audit oracle outdated issues (#63) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * removed admin * add assert to testOwnerAuthorize * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * erased dup test * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * 46 audit oracle outdated issues (#63) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * dup of trigger null epoch Co-authored-by: 0xnexusflip <[email protected]> * missing address * 69 audit depeg event can happen at incorrect price (#70) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * audit: timelock in admin functions of vault #66 * audit: getLatestPrice in event of triggerEndEpoch * audit: Change the isDisaster modifier to revert when price of a pegged asset is equal to the strike price of a Vault * epochHasEnded * goerli deployment * natspec comments * add quick fix to test before PR refactoring * 46 audit oracle outdated issues (#63) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * removed admin * add assert to testOwnerAuthorize * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * unused local var * 66 audit timelock in admin functions of vault (#67) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * audit: timelock in admin functions of vault #66 * 41 audit getlatestprice when calling endepoch with sequencer down does not end and epoch (#68) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * audit: timelock in admin functions of vault #66 * audit: getLatestPrice in event of triggerEndEpoch * epochHasEnded * goerli deployment * natspec comments * add quick fix to test before PR refactoring * 46 audit oracle outdated issues (#63) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * removed admin * add assert to testOwnerAuthorize * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * erased dup test * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * 46 audit oracle outdated issues (#63) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * dup of trigger null epoch Co-authored-by: 0xnexusflip <[email protected]> * missing address Co-authored-by: 0xnexusflip <[email protected]> * audit: #383 * audit: #379 * audit #118 * remove hashed index * change treasure address 0 * deposit event with useless param * audit deposit evnt * audit: fee cannot be 0 * add timelock, strk price, null epoch tests * add testFeeCannotBe0 * add testControllerNotSet * timelock assert test * test fail for timelockers * tests of epochnull and withdraw without fee * test epoch already finished * EpochFinishedAlready and epochNull tests * testing suite update on reverts * comment out test testVaultAddressZero * assert on all asset.transfers Co-authored-by: 0xnexusflip <[email protected]> * Revert "71 audit missing assert verification on transfer of tokens (#81)" This reverts commit 79d913a. Co-authored-by: 0xnexusflip <[email protected]> * assert on all asset.transfers (#84) * add author to contracts * audit marketExists on controller functs (#85) * remove getNextEpoch * audit: Vault receiver != address(0) * audit: oracle for more than 18 and for less than 18 decimals * audit: multiply before dividing #77 * test out lowest fee possible * audit: #79 * timelock for factory instead of vault * onlyAdmin to onlyOwner Ownable * fix overflow on previewWithdraw * fee calculation on premium * fix testWithdrawDepeg() and WithdrawEndEpoch() * revert event naming in RewardsFactory * removed hashed index * add testOracleDecimals() template * change strike on deploy script * qa for oracle decimals * timelocker contract with queue and execute * policy role * policy == owner * remove rewards duration and rewards rate * useless rewardsDuration and rewardRate * config json * json parser * deploy with json config * deploy more assets script * when not paused, claiming rewards can proceed Co-authored-by: 0xnexusflip <[email protected]>

* 46 audit oracle outdated issues (#63) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * removed admin * add assert to testOwnerAuthorize * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * unused local var * 66 audit timelock in admin functions of vault (#67) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * audit: timelock in admin functions of vault #66 * 41 audit getlatestprice when calling endepoch with sequencer down does not end and epoch (#68) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * audit: timelock in admin functions of vault #66 * audit: getLatestPrice in event of triggerEndEpoch * epochHasEnded * goerli deployment * natspec comments * add quick fix to test before PR refactoring * 46 audit oracle outdated issues (#63) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * removed admin * add assert to testOwnerAuthorize * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * erased dup test * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * 46 audit oracle outdated issues (#63) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * dup of trigger null epoch Co-authored-by: 0xnexusflip <[email protected]> * missing address * 69 audit depeg event can happen at incorrect price (#70) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * audit: timelock in admin functions of vault #66 * audit: getLatestPrice in event of triggerEndEpoch * audit: Change the isDisaster modifier to revert when price of a pegged asset is equal to the strike price of a Vault * epochHasEnded * goerli deployment * natspec comments * add quick fix to test before PR refactoring * 46 audit oracle outdated issues (#63) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * removed admin * add assert to testOwnerAuthorize * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * unused local var * 66 audit timelock in admin functions of vault (#67) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * audit: timelock in admin functions of vault #66 * 41 audit getlatestprice when calling endepoch with sequencer down does not end and epoch (#68) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * audit: timelock in admin functions of vault #66 * audit: getLatestPrice in event of triggerEndEpoch * epochHasEnded * goerli deployment * natspec comments * add quick fix to test before PR refactoring * 46 audit oracle outdated issues (#63) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * removed admin * add assert to testOwnerAuthorize * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * erased dup test * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * 46 audit oracle outdated issues (#63) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * dup of trigger null epoch Co-authored-by: 0xnexusflip <[email protected]> * missing address Co-authored-by: 0xnexusflip <[email protected]> * audit: #383 * audit: #379 * audit #118 * remove hashed index * change treasure address 0 * deposit event with useless param * audit deposit evnt * audit: fee cannot be 0 * add timelock, strk price, null epoch tests * add testFeeCannotBe0 * add testControllerNotSet * timelock assert test * test fail for timelockers * tests of epochnull and withdraw without fee * test epoch already finished * EpochFinishedAlready and epochNull tests * testing suite update on reverts * comment out test testVaultAddressZero * Revert 81 71 audit missing assert verification on transfer of tokens (#82) * 71 audit missing assert verification on transfer of tokens (#81) * 46 audit oracle outdated issues (#63) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * removed admin * add assert to testOwnerAuthorize * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * unused local var * 66 audit timelock in admin functions of vault (#67) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * audit: timelock in admin functions of vault #66 * 41 audit getlatestprice when calling endepoch with sequencer down does not end and epoch (#68) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * audit: timelock in admin functions of vault #66 * audit: getLatestPrice in event of triggerEndEpoch * epochHasEnded * goerli deployment * natspec comments * add quick fix to test before PR refactoring * 46 audit oracle outdated issues (#63) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * removed admin * add assert to testOwnerAuthorize * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * erased dup test * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * 46 audit oracle outdated issues (#63) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * dup of trigger null epoch Co-authored-by: 0xnexusflip <[email protected]> * missing address * 69 audit depeg event can happen at incorrect price (#70) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * audit: timelock in admin functions of vault #66 * audit: getLatestPrice in event of triggerEndEpoch * audit: Change the isDisaster modifier to revert when price of a pegged asset is equal to the strike price of a Vault * epochHasEnded * goerli deployment * natspec comments * add quick fix to test before PR refactoring * 46 audit oracle outdated issues (#63) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * removed admin * add assert to testOwnerAuthorize * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * unused local var * 66 audit timelock in admin functions of vault (#67) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * audit: timelock in admin functions of vault #66 * 41 audit getlatestprice when calling endepoch with sequencer down does not end and epoch (#68) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * audit: timelock in admin functions of vault #66 * audit: getLatestPrice in event of triggerEndEpoch * epochHasEnded * goerli deployment * natspec comments * add quick fix to test before PR refactoring * 46 audit oracle outdated issues (#63) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * removed admin * add assert to testOwnerAuthorize * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * erased dup test * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * 46 audit oracle outdated issues (#63) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * 39 audit controllersol needs to implement tvl cant be zero (#64) * audit: remove approving of WETH when Depositing Eth * audit: Vault.sol mapping to epochs is over * natspec example * synthax errors on compile * useless onlyAdmin * audit: Controller.sol needs to implement TVL cant be zero * total supply and modifier * allow rest only after epoch begins * dup of trigger null epoch Co-authored-by: 0xnexusflip <[email protected]> * missing address Co-authored-by: 0xnexusflip <[email protected]> * audit: #383 * audit: #379 * audit #118 * remove hashed index * change treasure address 0 * deposit event with useless param * audit deposit evnt * audit: fee cannot be 0 * add timelock, strk price, null epoch tests * add testFeeCannotBe0 * add testControllerNotSet * timelock assert test * test fail for timelockers * tests of epochnull and withdraw without fee * test epoch already finished * EpochFinishedAlready and epochNull tests * testing suite update on reverts * comment out test testVaultAddressZero * assert on all asset.transfers Co-authored-by: 0xnexusflip <[email protected]> * Revert "71 audit missing assert verification on transfer of tokens (#81)" This reverts commit 79d913a. Co-authored-by: 0xnexusflip <[email protected]> * assert on all asset.transfers (#84) * add author to contracts * audit marketExists on controller functs (#85) * remove getNextEpoch * audit: Vault receiver != address(0) * audit: oracle for more than 18 and for less than 18 decimals * audit: multiply before dividing #77 * test out lowest fee possible * audit: #79 * timelock for factory instead of vault * onlyAdmin to onlyOwner Ownable * fix overflow on previewWithdraw * fee calculation on premium * fix testWithdrawDepeg() and WithdrawEndEpoch() * revert event naming in RewardsFactory * removed hashed index * add testOracleDecimals() template * change strike on deploy script * qa for oracle decimals * timelocker contract with queue and execute * policy role * policy == owner * remove rewards duration and rewards rate * useless rewardsDuration and rewardRate * config json * json parser * deploy with json config * deploy more assets script * add fake weth * fakeweth mint * /out => abi/ * abi ignore * commands to work * deploy more markets * deploy more scripts * _index * remove redundant epoch end * commands * pausable staking rewards Co-authored-by: 0xnexusflip <[email protected]> Co-authored-by: mcruzvas <[email protected]>

MiguelBits added 6 commits September 23, 2022 16:17

audit: remove approving of WETH when Depositing Eth

b42e2bc

audit: Vault.sol mapping to epochs is over

d87192f

natspec example

7139ebb

synthax errors on compile

22112e0

useless onlyAdmin

f0db891

audit: Controller.sol needs to implement TVL cant be zero

6a908c1

MiguelBits requested a review from 0xnexusflip September 23, 2022 17:08

MiguelBits assigned 3xHarry Sep 23, 2022

MiguelBits linked an issue Sep 23, 2022 that may be closed by this pull request

audit: Controller.sol needs to implement TVL cant be zero #39

Closed

MiguelBits added 3 commits September 23, 2022 18:46

total supply and modifier

516da7d

allow rest only after epoch begins

8e3f1ff

Merge branch 'main' into 39-audit-controllersol-needs-to-implement-tv…

775efc7

…l-cant-be-zero

MiguelBits changed the base branch from main to aufit-implementations September 29, 2022 17:06

Merge branch 'audit-implementations' into 39-audit-controllersol-need…

df2dc1e

…s-to-implement-tvl-cant-be-zero

MiguelBits merged commit 13a0caf into audit-implementations Sep 29, 2022

3xHarry reviewed Oct 4, 2022

View reviewed changes

MiguelBits deleted the 39-audit-controllersol-needs-to-implement-tvl-cant-be-zero branch October 12, 2022 17:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

39 audit controllersol needs to implement tvl cant be zero #64

39 audit controllersol needs to implement tvl cant be zero #64

MiguelBits commented Sep 23, 2022

3xHarry Oct 4, 2022

39 audit controllersol needs to implement tvl cant be zero #64

39 audit controllersol needs to implement tvl cant be zero #64

Conversation

MiguelBits commented Sep 23, 2022

3xHarry Oct 4, 2022

Choose a reason for hiding this comment